stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8245128: Kitchensink fails with: assert(destination == (address)-1 || destination == entry) failed: b) MT-unsafe modification of inline cache

Browse Source 
Fix too strong assertion by additionally considering races due to class unloading and redefinition.

Reviewed-by: eosterlund, kvn, coleenp, sspitsyn
This commit is contained in:
Christian Hagedorn 2020-06-25 11:43:20 +02:00
parent 31c511e6a5
commit 601e566b26
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hotspot/share/code/compiledIC.cpp
View File

@ -756,7 +756,9 @@ void CompiledDirectStaticCall::verify_mt_safe(const methodHandle& callee, addres
"a) MT-unsafe modification of inline cache"); "a) MT-unsafe modification of inline cache");
address destination = jump->jump_destination(); address destination = jump->jump_destination();
assert(destination == (address)-1 || destination == entry, assert(destination == (address)-1 || destination == entry
|| old_method == NULL || !old_method->method_holder()->is_loader_alive() // may have a race due to class unloading.
|| old_method->is_old(), // may be race patching deoptimized nmethod due to redefinition.
"b) MT-unsafe modification of inline cache"); "b) MT-unsafe modification of inline cache");
} }
#endif // !PRODUCT #endif // !PRODUCT