stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8237045: JVM uses excessive memory with -XX:+EnableJVMCI -XX:JVMCICounterSize=2147483648

Browse Source 
Limit JVMCICounterSize flag's value range to 1M

Reviewed-by: thartmann, redestad
This commit is contained in:
Vladimir Kozlov 2020-03-17 12:42:48 -07:00
parent 176192499f
commit 6083173f9b
3 changed files with 21 additions and 2 deletions
src/hotspot/share/jvmci
jvmci_globals.hpp
test/hotspot/jtreg/runtime/CommandLine/OptionsValidation
TestOptionsWithRanges.java
common/optionsvalidation
JVMOptionsUtils.java

7
src/hotspot/share/jvmci/jvmci_globals.hpp

@ -84,7 +84,8 @@ class fileStream;
\
NOT_COMPILER2(product(intx, MaxVectorSize, 64, \
"Max vector size in bytes, " \
"actual size could be less depending on elements type")) \
"actual size could be less depending on elements type") \
range(0, max_jint)) \
\
NOT_COMPILER2(product(bool, ReduceInitialCardMarks, true, \
"Defer write barriers of young objects")) \
@ -93,10 +94,11 @@ class fileStream;
"Trace level for JVMCI: " \
"1 means emit a message for each CompilerToVM call," \
"levels greater than 1 provide progressively greater detail") \
range(0, 6) \
\
experimental(intx, JVMCICounterSize, 0, \
"Reserved size for benchmark counters") \
range(0, max_jint) \
range(0, 1000000) \
\
experimental(bool, JVMCICountersExcludeCompiler, true, \
"Exclude JVMCI compiler threads from benchmark counters") \
@ -106,6 +108,7 @@ class fileStream;
\
experimental(intx, JVMCINMethodSizeLimit, (80*K)*wordSize, \
"Maximum size of a compiled method.") \
range(0, max_jint) \
\
experimental(ccstr, JVMCILibPath, NULL, \
"LD path for loading the JVMCI shared library") \

6
test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java

@ -213,6 +213,12 @@ public class TestOptionsWithRanges {
*/
excludeTestMaxRange("CICompilerCount");
/*
* Exclude JVMCI threads counts from testing similar to other threads counts.
*/
excludeTestMaxRange("JVMCIThreads");
excludeTestMaxRange("JVMCIHostThreads");
/*
* Exclude MallocMaxTestWords as it is expected to exit VM at small values (>=0)
*/

10
test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java

@ -185,6 +185,10 @@ public class JVMOptionsUtils {
option.addPrepend("-XX:+UseNUMA");
}
if (name.contains("JVMCI")) {
option.addPrepend("-XX:+EnableJVMCI");
}
switch (name) {
case "MinHeapFreeRatio":
option.addPrepend("-XX:MaxHeapFreeRatio=100");
@ -223,6 +227,12 @@ public class JVMOptionsUtils {
case "TLABWasteIncrement":
option.addPrepend("-XX:+UseParallelGC");
break;
case "BootstrapJVMCI":
case "PrintBootstrap":
case "JVMCIThreads":
case "JVMCIHostThreads":
option.addPrepend("-XX:+UseJVMCICompiler");
break;
default:
/* Do nothing */
break;