stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8029395: SA: jstack throws WrongTypeException

Browse Source 
SA missed some TLABs

Reviewed-by: dsamersoff, mgerdin, brutisso
This commit is contained in:
Staffan Larsen 2013-12-04 14:43:50 +01:00
parent 9169a8f064
commit 62e1b6eddd
2 changed files with 38 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
hotspot/agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java
View File

@ -364,7 +364,7 @@ public class ObjectHeap {
} }
catch (AddressException e) { catch (AddressException e) {
// This is okay at the top of these regions // This is okay at the top of these regions
} }
catch (UnknownOopException e) { catch (UnknownOopException e) {
// This is okay at the top of these regions // This is okay at the top of these regions
} }
@ -373,7 +373,7 @@ public class ObjectHeap {
visitor.epilogue(); visitor.epilogue();
} }
private void addLiveRegions(List input, List output) { private void addLiveRegions(String name, List input, List output) {
for (Iterator itr = input.iterator(); itr.hasNext();) { for (Iterator itr = input.iterator(); itr.hasNext();) {
MemRegion reg = (MemRegion) itr.next(); MemRegion reg = (MemRegion) itr.next();
Address top = reg.end(); Address top = reg.end();
@ -386,6 +386,9 @@ public class ObjectHeap {
} }
output.add(top); output.add(top);
output.add(bottom); output.add(bottom);
if (DEBUG) {
System.err.println("Live region: " + name + ": " + bottom + ", " + top);
}
} }
} }
@ -395,7 +398,7 @@ public class ObjectHeap {
} }
public void doSpace(Space s) { public void doSpace(Space s) {
addLiveRegions(s.getLiveRegions(), liveRegions); addLiveRegions(s.toString(), s.getLiveRegions(), liveRegions);
} }
private List liveRegions; private List liveRegions;
} }
@ -426,11 +429,11 @@ public class ObjectHeap {
ParallelScavengeHeap psh = (ParallelScavengeHeap) heap; ParallelScavengeHeap psh = (ParallelScavengeHeap) heap;
PSYoungGen youngGen = psh.youngGen(); PSYoungGen youngGen = psh.youngGen();
// Add eden space // Add eden space
addLiveRegions(youngGen.edenSpace().getLiveRegions(), liveRegions); addLiveRegions("eden", youngGen.edenSpace().getLiveRegions(), liveRegions);
// Add from-space but not to-space // Add from-space but not to-space
addLiveRegions(youngGen.fromSpace().getLiveRegions(), liveRegions); addLiveRegions("from", youngGen.fromSpace().getLiveRegions(), liveRegions);
PSOldGen oldGen = psh.oldGen(); PSOldGen oldGen = psh.oldGen();
addLiveRegions(oldGen.objectSpace().getLiveRegions(), liveRegions); addLiveRegions("old ", oldGen.objectSpace().getLiveRegions(), liveRegions);
} else if (heap instanceof G1CollectedHeap) { } else if (heap instanceof G1CollectedHeap) {
G1CollectedHeap g1h = (G1CollectedHeap) heap; G1CollectedHeap g1h = (G1CollectedHeap) heap;
g1h.heapRegionIterate(lrc); g1h.heapRegionIterate(lrc);
@ -451,23 +454,27 @@ public class ObjectHeap {
if (VM.getVM().getUseTLAB()) { if (VM.getVM().getUseTLAB()) {
for (JavaThread thread = VM.getVM().getThreads().first(); thread != null; thread = thread.next()) { for (JavaThread thread = VM.getVM().getThreads().first(); thread != null; thread = thread.next()) {
if (thread.isJavaThread()) { ThreadLocalAllocBuffer tlab = thread.tlab();
ThreadLocalAllocBuffer tlab = thread.tlab(); if (tlab.start() != null) {
if (tlab.start() != null) { if ((tlab.top() == null) || (tlab.end() == null)) {
if ((tlab.top() == null) || (tlab.end() == null)) { System.err.print("Warning: skipping invalid TLAB for thread ");
System.err.print("Warning: skipping invalid TLAB for thread "); thread.printThreadIDOn(System.err);
System.err.println();
} else {
if (DEBUG) {
System.err.print("TLAB for " + thread.getThreadName() + ", #");
thread.printThreadIDOn(System.err); thread.printThreadIDOn(System.err);
System.err.println(); System.err.print(": ");
} else { tlab.printOn(System.err);
// Go from:
// - below start() to start()
// - start() to top()
// - end() and above
liveRegions.add(tlab.start());
liveRegions.add(tlab.start());
liveRegions.add(tlab.top());
liveRegions.add(tlab.hardEnd());
} }
// Go from:
// - below start() to start()
// - start() to top()
// - end() and above
liveRegions.add(tlab.start());
liveRegions.add(tlab.start());
liveRegions.add(tlab.top());
liveRegions.add(tlab.hardEnd());
} }
} }
} }
@ -480,6 +487,15 @@ public class ObjectHeap {
Assert.that(liveRegions.size() % 2 == 0, "Must have even number of region boundaries"); Assert.that(liveRegions.size() % 2 == 0, "Must have even number of region boundaries");
} }
if (DEBUG) {
System.err.println("liveRegions:");
for (int i = 0; i < liveRegions.size(); i += 2) {
Address bottom = (Address) liveRegions.get(i);
Address top = (Address) liveRegions.get(i+1);
System.err.println(" " + bottom + " - " + top);
}
}
return liveRegions; return liveRegions;
} }

2
hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/ThreadLocalAllocBuffer.java
View File

@ -109,6 +109,6 @@ public class ThreadLocalAllocBuffer extends VMObject {
public void printOn(PrintStream tty) { public void printOn(PrintStream tty) {
tty.println(" [" + start() + "," + tty.println(" [" + start() + "," +
top() + "," + end() + ")"); top() + "," + end() + ",{" + hardEnd() + "})");
} }
} }