8338315: G1: G1CardTableEntryClosure:do_card_ptr remove unused parameter worker_id

Reviewed-by: tschatzl
This commit is contained in:
Ivan Walulya 2024-08-14 09:13:21 +00:00
parent 3dd07b91bb
commit 66bee2532f
3 changed files with 5 additions and 5 deletions

View File

@ -36,7 +36,7 @@ public:
typedef CardTable::CardValue CardValue;
// Process the card whose card table entry is "card_ptr".
virtual void do_card_ptr(CardValue* card_ptr, uint worker_id) = 0;
virtual void do_card_ptr(CardValue* card_ptr) = 0;
// Process all the card_ptrs in node.
void apply_to_buffer(BufferNode* node, uint worker_id) {
@ -44,7 +44,7 @@ public:
size_t capacity = node->capacity();
for (size_t i = node->index(); i < capacity; ++i) {
CardValue* card_ptr = static_cast<CardValue*>(buffer[i]);
do_card_ptr(card_ptr, worker_id);
do_card_ptr(card_ptr);
}
}
};

View File

@ -1230,11 +1230,10 @@ class G1MergeHeapRootsTask : public WorkerTask {
_cards_skipped(0)
{}
void do_card_ptr(CardValue* card_ptr, uint worker_id) {
void do_card_ptr(CardValue* card_ptr) override {
// The only time we care about recording cards that
// contain references that point into the collection set
// is during RSet updating within an evacuation pause.
// In this case worker_id should be the id of a GC worker thread.
assert(SafepointSynchronize::is_at_safepoint(), "not during an evacuation pause");
uint const region_idx = _ct->region_idx_for(card_ptr);
@ -1342,6 +1341,7 @@ public:
FREE_C_HEAP_ARRAY(Stack, _dirty_card_buffers);
}
}
virtual void work(uint worker_id) {
G1CollectedHeap* g1h = G1CollectedHeap::heap();
G1GCPhaseTimes* p = g1h->phase_times();

View File

@ -522,7 +522,7 @@ public:
_g1_ct(g1h->card_table()),
_evac_failure_regions(evac_failure_regions) { }
void do_card_ptr(CardValue* card_ptr, uint worker_id) {
void do_card_ptr(CardValue* card_ptr) override {
G1HeapRegion* hr = region_for_card(card_ptr);
// Should only dirty cards in regions that won't be freed.