stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

6839599: JVM crash while profiling Tomcat and Liferay

Browse Source 
ConstantPoolOopDesc::copy_cpool_bytes() - do the brute-force search search through 'tbl' when SymbolTable::lookup_only() returns NULL

Reviewed-by: kamg
This commit is contained in:
Tomas Hurka 2009-05-20 09:36:53 +02:00
parent 6d918271d5
commit 6ee565c7b8
1 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
hotspot/src/share/vm/oops/constantPoolOop.cpp
View File

@ -1181,7 +1181,28 @@ int constantPoolOopDesc::copy_cpool_bytes(int cpool_size,
unsigned int hash;
char *str = string_at_noresolve(idx);
symbolOop sym = SymbolTable::lookup_only(str, (int) strlen(str), hash);
idx1 = tbl->symbol_to_value(sym);
if (sym == NULL) {
// sym can be NULL if string refers to incorrectly encoded JVM_CONSTANT_Utf8
// this can happen with JVM TI; see CR 6839599 for more details
oop string = *(obj_at_addr(idx));
assert(java_lang_String::is_instance(string),"Not a String");
DBG(printf("Error #%03hd tag=%03hd\n", idx, tag));
idx1 = 0;
for (int j = 0; j < tbl->table_size() && idx1 == 0; j++) {
for (SymbolHashMapEntry* cur = tbl->bucket(j); cur != NULL; cur = cur->next()) {
int length;
sym = cur->symbol();
jchar* chars = sym->as_unicode(length);
if (java_lang_String::equals(string, chars, length)) {
idx1 = cur->value();
DBG(printf("Index found: %d\n",idx1));
break;
}
}
}
} else {
idx1 = tbl->symbol_to_value(sym);
}
assert(idx1 != 0, "Have not found a hashtable entry");
Bytes::put_Java_u2((address) (bytes+1), idx1);
DBG(printf("JVM_CONSTANT_String: idx=#%03hd, %s", idx1, str));