stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8259267: Refactor LoaderLeak shell test as java test.

Browse Source 
Reviewed-by: rriggs, iignatyev, dfuchs
This commit is contained in:
Ivan Šipka 2021-03-03 20:02:57 +00:00 committed by Igor Ignatyev
parent a11818528a
commit 75aa15467e
6 changed files with 135 additions and 305 deletions

135
test/jdk/java/lang/annotation/LoaderLeakTest.java Normal file

@ -0,0 +1,135 @@
/*
* Copyright (c) 2004, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 5040740
* @summary annotations cause memory leak
* @library /test/lib
* @build jdk.test.lib.process.*
* @run testng LoaderLeakTest
*/
import jdk.test.lib.Utils;
import jdk.test.lib.process.ProcessTools;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
import java.io.FileInputStream;
import java.lang.annotation.Retention;
import java.lang.ref.Reference;
import java.lang.ref.WeakReference;
import java.nio.file.*;
import java.util.*;
import static java.lang.annotation.RetentionPolicy.RUNTIME;
public class LoaderLeakTest {
@Test
public void testWithoutReadingAnnotations() throws Throwable {
runJavaProcessExpectSuccessExitCode("Main");
}
@Test
public void testWithReadingAnnotations() throws Throwable {
runJavaProcessExpectSuccessExitCode("Main", "foo");
}
private void runJavaProcessExpectSuccessExitCode(String ... command) throws Throwable {
var processBuilder = ProcessTools.createJavaProcessBuilder(command)
.directory(Paths.get(Utils.TEST_CLASSES).toFile());
ProcessTools.executeCommand(processBuilder).shouldHaveExitValue(0);
}
}
class Main {
public static void main(String[] args) throws Exception {
for (int i = 0; i < 100; i++) {
doTest(args.length != 0);
}
}
static void doTest(boolean readAnn) throws Exception {
ClassLoader loader = new SimpleClassLoader();
var c = new WeakReference<Class<?>>(loader.loadClass("C"));
if (c.refersTo(null)) throw new AssertionError("class missing after loadClass");
// c.get() should never return null here since we hold a strong
// reference to the class loader that loaded the class referred by c.
if (c.get().getClassLoader() != loader) throw new AssertionError("wrong classloader");
if (readAnn) System.out.println(c.get().getAnnotations()[0]);
if (c.refersTo(null)) throw new AssertionError("class missing before GC");
System.gc();
System.gc();
if (c.refersTo(null)) throw new AssertionError("class missing after GC but before loader is unreachable");
System.gc();
System.gc();
Reference.reachabilityFence(loader);
loader = null;
// Might require multiple calls to System.gc() for weak-references
// processing to be complete. If the weak-reference is not cleared as
// expected we will hang here until timed out by the test harness.
while (true) {
System.gc();
Thread.sleep(20);
if (c.refersTo(null)) {
break;
}
}
}
}
@Retention(RUNTIME)
@interface A {
B b();
}
@interface B { }
@A(b=@B()) class C { }
class SimpleClassLoader extends ClassLoader {
public SimpleClassLoader() { }
private byte[] getClassImplFromDataBase(String className) {
try {
return Files.readAllBytes(Paths.get(className + ".class"));
} catch (Exception e) {
throw new Error("could not load class " + className, e);
}
}
@Override
public Class<?> loadClass(String className, boolean resolveIt)
throws ClassNotFoundException {
switch (className) {
case "A", "B", "C" -> {
var classData = getClassImplFromDataBase(className);
return defineClass(className, classData, 0, classData.length);
}
}
return super.loadClass(className, resolveIt);
}
}

28
test/jdk/java/lang/annotation/loaderLeak/A.java

@ -1,28 +0,0 @@
/*
* Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
public
@java.lang.annotation.Retention(java.lang.annotation.RetentionPolicy.RUNTIME)
@interface A {
B b();
}

24
test/jdk/java/lang/annotation/loaderLeak/B.java

@ -1,24 +0,0 @@
/*
* Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
public @interface B {}

24
test/jdk/java/lang/annotation/loaderLeak/C.java

@ -1,24 +0,0 @@
/*
* Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
public @A(b=@B()) class C {}

93
test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh

@ -1,93 +0,0 @@
#!/bin/sh
# Copyright (c) 2004, 2020, Oracle and/or its affiliates. All rights reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
# This code is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License version 2 only, as
# published by the Free Software Foundation.
#
# This code is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
# version 2 for more details (a copy is included in the LICENSE file that
# accompanied this code).
#
# You should have received a copy of the GNU General Public License version
# 2 along with this work; if not, write to the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
#
# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
# or visit www.oracle.com if you need additional information or have any
# questions.
if [ "${TESTSRC}" = "" ]
then
echo "TESTSRC not set. Test cannot execute. Failed."
exit 1
fi
echo "TESTSRC=${TESTSRC}"
if [ "${TESTJAVA}" = "" ]
then
echo "TESTJAVA not set. Test cannot execute. Failed."
exit 1
fi
echo "TESTJAVA=${TESTJAVA}"
if [ "${COMPILEJAVA}" = "" ]; then
COMPILEJAVA="${TESTJAVA}"
fi
echo "COMPILEJAVA=${COMPILEJAVA}"
if [ "${TESTCLASSES}" = "" ]
then
echo "TESTCLASSES not set. Test cannot execute. Failed."
exit 1
fi
echo "TESTCLASSES=${TESTCLASSES}"
echo "CLASSPATH=${CLASSPATH}"
# set platform-dependent variables
OS=`uname -s`
case "$OS" in
Linux | Darwin | AIX )
NULL=/dev/null
PS=":"
FS="/"
;;
CYGWIN* )
NULL=/dev/null
PS=";"
FS="/"
;;
Windows* )
NULL=NUL
PS=";"
FS="\\"
;;
* )
echo "Unrecognized system!"
exit 1;
;;
esac
mkdir -p classes
cp ${TESTSRC}${FS}*.java .
${COMPILEJAVA}${FS}bin${FS}javac ${TESTJAVACOPTS} ${TESTTOOLVMOPTS} -d classes A.java B.java C.java
${COMPILEJAVA}${FS}bin${FS}javac ${TESTJAVACOPTS} ${TESTTOOLVMOPTS} Main.java
${TESTJAVA}${FS}bin${FS}java ${TESTVMOPTS} Main
result=$?
if [ $result -eq 0 ]
then
echo "Passed 1 of 2"
else
echo "Failed 1 of 2"
exit $result
fi
${TESTJAVA}${FS}bin${FS}java ${TESTVMOPTS} Main foo
result=$?
if [ $result -eq 0 ]
then
echo "Passed 2 of 2"
else
echo "Failed 2 of 2"
fi
exit $result

136
test/jdk/java/lang/annotation/loaderLeak/Main.java

@ -1,136 +0,0 @@
/*
* Copyright (c) 2004, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 5040740
* @summary annotations cause memory leak
* @author gafter
*
* @run shell LoaderLeak.sh
*/
import java.net.*;
import java.lang.ref.*;
import java.util.*;
import java.io.*;
public class Main {
public static void main(String[] args) throws Exception {
for (int i=0; i<100; i++)
doTest(args.length != 0);
}
static void doTest(boolean readAnn) throws Exception {
// URL classes = new URL("file://" + System.getProperty("user.dir") + "/classes");
// URL[] path = { classes };
// URLClassLoader loader = new URLClassLoader(path);
ClassLoader loader = new SimpleClassLoader();
WeakReference<Class<?>> c = new WeakReference(loader.loadClass("C"));
if (c.get() == null) throw new AssertionError();
if (c.get().getClassLoader() != loader) throw new AssertionError();
if (readAnn) System.out.println(c.get().getAnnotations()[0]);
if (c.get() == null) throw new AssertionError();
System.gc();
System.gc();
if (c.get() == null) throw new AssertionError();
System.gc();
System.gc();
Reference.reachabilityFence(loader);
loader = null;
// Might require multiple calls to System.gc() for weak-references
// processing to be complete. If the weak-reference is not cleared as
// expected we will hang here until timed out by the test harness.
while (true) {
System.gc();
Thread.sleep(20);
if (c.get() == null) {
break;
}
}
}
}
class SimpleClassLoader extends ClassLoader {
private Hashtable classes = new Hashtable();
public SimpleClassLoader() {
}
private byte getClassImplFromDataBase(String className)[] {
byte result[];
try {
FileInputStream fi = new FileInputStream("classes/"+className+".class");
result = new byte[fi.available()];
fi.read(result);
return result;
} catch (Exception e) {
/*
* If we caught an exception, either the class wasnt found or it
* was unreadable by our process.
*/
return null;
}
}
public Class loadClass(String className) throws ClassNotFoundException {
return (loadClass(className, true));
}
public synchronized Class loadClass(String className, boolean resolveIt)
throws ClassNotFoundException {
Class result;
byte classData[];
/* Check our local cache of classes */
result = (Class)classes.get(className);
if (result != null) {
return result;
}
/* Check with the primordial class loader */
try {
result = super.findSystemClass(className);
return result;
} catch (ClassNotFoundException e) {
}
/* Try to load it from our repository */
classData = getClassImplFromDataBase(className);
if (classData == null) {
throw new ClassNotFoundException();
}
/* Define it (parse the class file) */
result = defineClass(classData, 0, classData.length);
if (result == null) {
throw new ClassFormatError();
}
if (resolveIt) {
resolveClass(result);
}
classes.put(className, result);
return result;
}
}