stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8007761: NTLM coding errors

Browse Source 
Reviewed-by: chegar
This commit is contained in:
Weijun Wang 2013-02-09 16:43:58 +08:00
parent d8233ec657
commit 76953b4d1e
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
jdk/src/share/classes/com/sun/security/ntlm/Client.java
View File

@ -138,8 +138,7 @@ public final class Client extends NTLM {
domain = domainFromServer; domain = domainFromServer;
} }
if (domain == null) { if (domain == null) {
throw new NTLMException(NTLMException.NO_DOMAIN_INFO, domain = "";
"No domain info");
} }
int flags = 0x88200 | (inputFlags & 3); int flags = 0x88200 | (inputFlags & 3);

12
jdk/src/share/classes/com/sun/security/ntlm/NTLM.java
View File

@ -136,10 +136,10 @@ class NTLM {
int readInt(int offset) throws NTLMException { int readInt(int offset) throws NTLMException {
try { try {
return internal[offset] & 0xff + return (internal[offset] & 0xff) +
(internal[offset+1] & 0xff << 8) + ((internal[offset+1] & 0xff) << 8) +
(internal[offset+2] & 0xff << 16) + ((internal[offset+2] & 0xff) << 16) +
(internal[offset+3] & 0xff << 24); ((internal[offset+3] & 0xff) << 24);
} catch (ArrayIndexOutOfBoundsException ex) { } catch (ArrayIndexOutOfBoundsException ex) {
throw new NTLMException(NTLMException.PACKET_READ_ERROR, throw new NTLMException(NTLMException.PACKET_READ_ERROR,
"Input message incorrect size"); "Input message incorrect size");
@ -148,8 +148,8 @@ class NTLM {
int readShort(int offset) throws NTLMException { int readShort(int offset) throws NTLMException {
try { try {
return internal[offset] & 0xff + return (internal[offset] & 0xff) +
(internal[offset+1] & 0xff << 8); ((internal[offset+1] & 0xff << 8));
} catch (ArrayIndexOutOfBoundsException ex) { } catch (ArrayIndexOutOfBoundsException ex) {
throw new NTLMException(NTLMException.PACKET_READ_ERROR, throw new NTLMException(NTLMException.PACKET_READ_ERROR,
"Input message incorrect size"); "Input message incorrect size");