8245801: StressRecompilation triggers assert "redundunt OSR recompilation detected. memory leak in CodeCache!"

Assert is too strong.

Reviewed-by: roland
This commit is contained in:
Tobias Hartmann 2020-05-27 13:26:23 +02:00
parent 5200d162bc
commit 76ac621394
2 changed files with 43 additions and 3 deletions
src/hotspot/share/oops
test/hotspot/jtreg/compiler/c2

@ -3087,9 +3087,9 @@ void InstanceKlass::add_osr_nmethod(nmethod* n) {
assert_lock_strong(CompiledMethod_lock);
#ifndef PRODUCT
if (TieredCompilation) {
nmethod * prev = lookup_osr_nmethod(n->method(), n->osr_entry_bci(), n->comp_level(), true);
assert(prev == NULL || !prev->is_in_use(),
"redundunt OSR recompilation detected. memory leak in CodeCache!");
nmethod* prev = lookup_osr_nmethod(n->method(), n->osr_entry_bci(), n->comp_level(), true);
assert(prev == NULL || !prev->is_in_use() || StressRecompilation,
"redundant OSR recompilation detected. memory leak in CodeCache!");
}
#endif
// only one compilation can be active

@ -0,0 +1,40 @@
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8245801
* @requires vm.debug
* @summary Test running with StressRecompilation enabled.
* @run main/othervm -Xcomp -XX:+IgnoreUnrecognizedVMOptions -XX:+StressRecompilation
* compiler.c2.TestStressRecompilation
*/
package compiler.c2;
public class TestStressRecompilation {
public static void main(String[] args) {
System.out.println("Test passed.");
}
}