stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8079843: do_young_space_rescan - comment out of sync with code

Browse Source 
Reviewed-by: mgerdin, sjohanss, ehelin, tschatzl
This commit is contained in:
Stefan Karlsson 2016-04-20 09:58:15 +02:00
parent 277996e430
commit 790431bd5d
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
hotspot/src/share/vm/gc/cms/concurrentMarkSweepGeneration.cpp
View File

@ -2769,10 +2769,10 @@ class CMSParMarkTask : public AbstractGangTask {
_collector(collector),
_n_workers(n_workers) {}
// Work method in support of parallel rescan ... of young gen spaces
void do_young_space_rescan(uint worker_id, OopsInGenClosure* cl,
void do_young_space_rescan(OopsInGenClosure* cl,
ContiguousSpace* space,
HeapWord** chunk_array, size_t chunk_top);
void work_on_young_gen_roots(uint worker_id, OopsInGenClosure* cl);
void work_on_young_gen_roots(OopsInGenClosure* cl);
};
// Parallel initial mark task
@ -4255,7 +4255,7 @@ void CMSParInitialMarkTask::work(uint worker_id) {
// ---------- young gen roots --------------
{
work_on_young_gen_roots(worker_id, &par_mri_cl);
work_on_young_gen_roots(&par_mri_cl);
_timer.stop();
log_trace(gc, task)("Finished young gen initial mark scan work in %dth thread: %3.3f sec", worker_id, _timer.seconds());
}
@ -4346,7 +4346,7 @@ class RemarkKlassClosure : public KlassClosure {
}
};
void CMSParMarkTask::work_on_young_gen_roots(uint worker_id, OopsInGenClosure* cl) {
void CMSParMarkTask::work_on_young_gen_roots(OopsInGenClosure* cl) {
ParNewGeneration* young_gen = _collector->_young_gen;
ContiguousSpace* eden_space = young_gen->eden();
ContiguousSpace* from_space = young_gen->from();
@ -4360,9 +4360,9 @@ void CMSParMarkTask::work_on_young_gen_roots(uint worker_id, OopsInGenClosure* c
assert(ect <= _collector->_eden_chunk_capacity, "out of bounds");
assert(sct <= _collector->_survivor_chunk_capacity, "out of bounds");
do_young_space_rescan(worker_id, cl, to_space, NULL, 0);
do_young_space_rescan(worker_id, cl, from_space, sca, sct);
do_young_space_rescan(worker_id, cl, eden_space, eca, ect);
do_young_space_rescan(cl, to_space, NULL, 0);
do_young_space_rescan(cl, from_space, sca, sct);
do_young_space_rescan(cl, eden_space, eca, ect);
}
// work_queue(i) is passed to the closure
@ -4389,7 +4389,7 @@ void CMSParRemarkTask::work(uint worker_id) {
// work first.
// ---------- young gen roots --------------
{
work_on_young_gen_roots(worker_id, &par_mrias_cl);
work_on_young_gen_roots(&par_mrias_cl);
_timer.stop();
log_trace(gc, task)("Finished young gen rescan work in %dth thread: %3.3f sec", worker_id, _timer.seconds());
}
@ -4471,9 +4471,8 @@ void CMSParRemarkTask::work(uint worker_id) {
log_trace(gc, task)("Finished work stealing in %dth thread: %3.3f sec", worker_id, _timer.seconds());
}
// Note that parameter "i" is not used.
void
CMSParMarkTask::do_young_space_rescan(uint worker_id,
CMSParMarkTask::do_young_space_rescan(
OopsInGenClosure* cl, ContiguousSpace* space,
HeapWord** chunk_array, size_t chunk_top) {
// Until all tasks completed: