8227652: SetupOperatorNewDeleteCheck should discuss deleting destructors

Add comment describing deleting destructors

Reviewed-by: dholmes
This commit is contained in:
Kim Barrett 2019-07-18 11:54:54 -04:00
parent 9b23ca4eb4
commit 7b176df9c9

View File

@ -260,6 +260,15 @@ TARGETS += $(BUILD_LIBJVM)
#
# Search the output for the operator(s) of interest, to see where they are
# referenced.
#
# When a reference to the global 'operator delete' is reported, it might be
# due to a "deleting destructor". In this case, objdump may show the
# reference to be associated with but not actually in a destructor. A
# deleting destructor is automatically generated for a class whose destructor
# is virtual. A deleting destructor requires an accessible 'operator delete'
# for the associated class. If the class doesn't provide a more specific
# declaration (either directly or by inheriting from a class that provides
# one) then the global definition will be used, triggering this check.
ifneq ($(GENERATE_COMPILE_COMMANDS_ONLY), true)
ifneq ($(filter $(TOOLCHAIN_TYPE), gcc clang solstudio), )