stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8322300: Remove redundant arg in PSAdaptiveSizePolicy::adjust_promo_for_pause_time

Browse Source 
Reviewed-by: tschatzl
This commit is contained in:
Albert Mingkun Yang 2023-12-19 08:39:45 +00:00
parent 76637c53c5
commit 7b4d62c794
2 changed files with 6 additions and 8 deletions

9
src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp

@ -455,7 +455,7 @@ void PSAdaptiveSizePolicy::compute_old_gen_free_space(
// at a time.
if (is_full_gc) {
set_decide_at_full_gc(decide_at_full_gc_true);
adjust_promo_for_pause_time(is_full_gc, &desired_promo_size, &desired_eden_size);
adjust_promo_for_pause_time(&desired_promo_size, &desired_eden_size);
}
} else if (adjusted_mutator_cost() < _throughput_goal) {
// This branch used to require that (mutator_cost() > 0.0 in 1.4.2.
@ -592,16 +592,15 @@ void PSAdaptiveSizePolicy::adjust_eden_for_minor_pause_time(size_t* desired_eden
}
}
void PSAdaptiveSizePolicy::adjust_promo_for_pause_time(bool is_full_gc,
size_t* desired_promo_size_ptr,
size_t* desired_eden_size_ptr) {
void PSAdaptiveSizePolicy::adjust_promo_for_pause_time(size_t* desired_promo_size_ptr,
size_t* desired_eden_size_ptr) {
size_t promo_heap_delta = 0;
// Add some checks for a threshold for a change. For example,
// a change less than the required alignment is probably not worth
// attempting.
if (_avg_minor_pause->padded_average() <= _avg_major_pause->padded_average() && is_full_gc) {
if (_avg_minor_pause->padded_average() <= _avg_major_pause->padded_average()) {
// Adjust for the major pause time only at full gc's because the
// affects of a change can only be seen at full gc's.

5
src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.hpp

@ -119,9 +119,8 @@ class PSAdaptiveSizePolicy : public AdaptiveSizePolicy {
void adjust_eden_for_minor_pause_time(size_t* desired_eden_size_ptr);
// Change the generation sizes to achieve a GC pause time goal
// Returned sizes are not necessarily aligned.
void adjust_promo_for_pause_time(bool is_full_gc,
size_t* desired_promo_size_ptr,
size_t* desired_eden_size_ptr);
void adjust_promo_for_pause_time(size_t* desired_promo_size_ptr,
size_t* desired_eden_size_ptr);
void adjust_eden_for_pause_time(size_t* desired_promo_size_ptr, size_t* desired_eden_size_ptr);
// Change the generation sizes to achieve an application throughput goal
// Returned sizes are not necessarily aligned.