stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

4265389: JSplitPane does not support ComponentOrientation

Browse Source 
Reviewed-by: tr, abhiscxk
This commit is contained in:
Prasanta Sadhukhan 2024-07-22 13:19:30 +00:00
parent c1fdc04ad7
commit 7ddd02599c
2 changed files with 98 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/java.desktop/share/classes/javax/swing/JSplitPane.java
View File

@ -26,6 +26,7 @@
package javax.swing;
import java.awt.Component;
import java.awt.ComponentOrientation;
import java.awt.Graphics;
import java.beans.BeanProperty;
import java.beans.ConstructorProperties;
@ -362,6 +363,32 @@ public class JSplitPane extends JComponent implements Accessible
}
/**
* {@inheritDoc}
* @param orientation {@inheritDoc}
*/
@Override
public void setComponentOrientation(ComponentOrientation orientation) {
super.setComponentOrientation(orientation);
Component leftComponent = this.getLeftComponent();
Component rightComponent = this.getRightComponent();
if (!this.getComponentOrientation().isLeftToRight()) {
if (rightComponent != null) {
setLeftComponent(rightComponent);
}
if (leftComponent != null) {
setRightComponent(leftComponent);
}
} else {
if (leftComponent != null) {
setLeftComponent(leftComponent);
}
if (rightComponent != null) {
setRightComponent(rightComponent);
}
}
}
/**
* {@inheritDoc}
* @param enabled {@inheritDoc}

71
test/jdk/javax/swing/JSplitPane/TestSplitPaneOrientationTest.java Normal file
View File

@ -0,0 +1,71 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 4265389
* @summary Verifies JSplitPane support ComponentOrientation
* @run main TestSplitPaneOrientationTest
*/
import java.awt.ComponentOrientation;
import javax.swing.JButton;
import javax.swing.JSplitPane;
import javax.swing.SwingUtilities;
import javax.swing.UIManager;
import javax.swing.UnsupportedLookAndFeelException;
public class TestSplitPaneOrientationTest {
private static void setLookAndFeel(UIManager.LookAndFeelInfo laf) {
try {
UIManager.setLookAndFeel(laf.getClassName());
} catch (UnsupportedLookAndFeelException ignored) {
System.out.println("Unsupported LAF: " + laf.getClassName());
} catch (ClassNotFoundException | InstantiationException
| IllegalAccessException e) {
throw new RuntimeException(e);
}
}
public static void main(String[] args) throws Exception {
for (UIManager.LookAndFeelInfo laf : UIManager.getInstalledLookAndFeels()) {
System.out.println("Testing LAF : " + laf.getClassName());
SwingUtilities.invokeAndWait(() -> {
setLookAndFeel(laf);
JSplitPane jsp = new JSplitPane(JSplitPane.HORIZONTAL_SPLIT,
new JButton("Left"), new JButton("Right"));
jsp.setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
if (jsp.getRightComponent() instanceof JButton button) {
System.out.println(button.getText());
if (!button.getText().equals("Left")) {
throw new RuntimeException("JSplitPane did not support ComponentOrientation");
}
}
});
}
}
}