stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8024914: Swapped usage of idx_t and bm_word_t types in bitMap.inline.hpp

Browse Source 
Incorrect usage of idx_t where bm_word_t is appropriate.

Reviewed-by: tschatzl, brutisso
This commit is contained in:
Dan Horak 2013-09-17 12:04:11 +02:00 committed by Thomas Schatzl
parent 05929860a5
commit 7e77954221
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
hotspot/src/share/vm/utilities/bitMap.inline.hpp
View File

@ -52,16 +52,16 @@ inline void BitMap::clear_bit(idx_t bit) {
inline bool BitMap::par_set_bit(idx_t bit) {
verify_index(bit);
volatile idx_t* const addr = word_addr(bit);
const idx_t mask = bit_mask(bit);
idx_t old_val = *addr;
volatile bm_word_t* const addr = word_addr(bit);
const bm_word_t mask = bit_mask(bit);
bm_word_t old_val = *addr;
do {
const idx_t new_val = old_val | mask;
const bm_word_t new_val = old_val | mask;
if (new_val == old_val) {
return false; // Someone else beat us to it.
}
const idx_t cur_val = (idx_t) Atomic::cmpxchg_ptr((void*) new_val,
const bm_word_t cur_val = (bm_word_t) Atomic::cmpxchg_ptr((void*) new_val,
(volatile void*) addr,
(void*) old_val);
if (cur_val == old_val) {
@ -73,16 +73,16 @@ inline bool BitMap::par_set_bit(idx_t bit) {
inline bool BitMap::par_clear_bit(idx_t bit) {
verify_index(bit);
volatile idx_t* const addr = word_addr(bit);
const idx_t mask = ~bit_mask(bit);
idx_t old_val = *addr;
volatile bm_word_t* const addr = word_addr(bit);
const bm_word_t mask = ~bit_mask(bit);
bm_word_t old_val = *addr;
do {
const idx_t new_val = old_val & mask;
const bm_word_t new_val = old_val & mask;
if (new_val == old_val) {
return false; // Someone else beat us to it.
}
const idx_t cur_val = (idx_t) Atomic::cmpxchg_ptr((void*) new_val,
const bm_word_t cur_val = (bm_word_t) Atomic::cmpxchg_ptr((void*) new_val,
(volatile void*) addr,
(void*) old_val);
if (cur_val == old_val) {