stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8178077: jshell tool: crash on ctrl-up or ctrl-down

Browse Source 
When looking up a private method, using the ConsoleReader.class, instead of getClass(), which may return a subclass.

Reviewed-by: rfield
This commit is contained in:
Jan Lahoda 2017-04-06 16:17:03 +02:00
parent c8873016c3
commit 8286fe95ee
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
jdk/src/jdk.internal.le/share/classes/jdk/internal/jline/extra/EditingHistory.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -74,7 +74,7 @@ public abstract class EditingHistory implements History {
//in.resetPromptLine(in.getPrompt(), in.getHistory().current().toString(), -1); //in.resetPromptLine(in.getPrompt(), in.getHistory().current().toString(), -1);
//but that would mean more re-writing on the screen, (and prints an additional //but that would mean more re-writing on the screen, (and prints an additional
//empty line), so using setBuffer directly: //empty line), so using setBuffer directly:
Method setBuffer = in.getClass().getDeclaredMethod("setBuffer", String.class); Method setBuffer = ConsoleReader.class.getDeclaredMethod("setBuffer", String.class);
setBuffer.setAccessible(true); setBuffer.setAccessible(true);
setBuffer.invoke(in, in.getHistory().current().toString()); setBuffer.invoke(in, in.getHistory().current().toString());