From 857a99a9e72dea0c388fd4b04441538f97bb9f4c Mon Sep 17 00:00:00 2001 From: Sergey Malenkov Date: Tue, 11 Jun 2013 16:02:22 +0400 Subject: [PATCH] 8015336: BasicComboBoxEditor throws NullPointerException Reviewed-by: alexsch --- .../swing/plaf/basic/BasicComboBoxEditor.java | 3 ++ .../BasicComboBoxEditor/Test8015336.java | 41 +++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 jdk/test/javax/swing/plaf/basic/BasicComboBoxEditor/Test8015336.java diff --git a/jdk/src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java b/jdk/src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java index 1b741db47f6..c902252f4dc 100644 --- a/jdk/src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java +++ b/jdk/src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java @@ -73,6 +73,9 @@ public class BasicComboBoxEditor implements ComboBoxEditor,FocusListener { if ( anObject != null ) { text = anObject.toString(); + if (text == null) { + text = ""; + } oldValue = anObject; } else { text = ""; diff --git a/jdk/test/javax/swing/plaf/basic/BasicComboBoxEditor/Test8015336.java b/jdk/test/javax/swing/plaf/basic/BasicComboBoxEditor/Test8015336.java new file mode 100644 index 00000000000..742fc99091a --- /dev/null +++ b/jdk/test/javax/swing/plaf/basic/BasicComboBoxEditor/Test8015336.java @@ -0,0 +1,41 @@ +/* + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +import javax.swing.JComboBox; + +/* + * @test + * @bug 8015336 + * @summary No NPE for BasicComboBoxEditor.setItem(null) + * @author Sergey Malenkov + */ +public class Test8015336 { + public static void main(String[] args) throws Exception { + new JComboBox().getEditor().setItem(new Test8015336()); + } + + @Override + public String toString() { + return null; + } +}