8214526: Change CodeHeap State Analytics control from UL to Print*

Reviewed-by: coleenp, kvn, stuefe, thartmann
This commit is contained in:
Lutz Schmidt 2018-12-04 11:57:18 +01:00
parent 45628a358a
commit 8e05550ef3
4 changed files with 12 additions and 15 deletions

View File

@ -1411,8 +1411,7 @@ void CodeCache::report_codemem_full(int code_blob_type, bool print) {
}
if (heap->full_count() == 0) {
LogTarget(Debug, codecache) lt;
if (lt.is_enabled()) {
if (PrintCodeHeapAnalytics) {
CompileBroker::print_heapinfo(tty, "all", "4096"); // details, may be a lot!
}
}

View File

@ -38,7 +38,7 @@
// Aggregation condenses the information of a piece of the CodeHeap
// (4096 bytes by default) into an analysis granule. These granules
// contain enough detail to gain initial insight while keeping the
// internal sttructure sizes in check.
// internal structure sizes in check.
//
// The CodeHeap is a living thing. Therefore, the aggregate is collected
// under the CodeCache_lock. The subsequent print steps are only locked
@ -63,15 +63,12 @@
//
// If you are (only) interested in how the CodeHeap looks like after running
// a sample workload, you can use the command line option
// -Xlog:codecache=Trace
// -XX:+PrintCodeHeapAnalytics
// It will cause a full analysis to be written to tty. In addition, a full
// analysis will be written the first time a "CodeCache full" condition is
// detected.
//
// To see the CodeHeap state in case of a "CodeCache full" condition, start the
// VM with the
// -Xlog:codecache=Debug
// command line option. It will produce output only for the first time the
// condition is recognized.
//
// Both command line option variants produce output identical to the jcmd function
// The command line option produces output identical to the jcmd function
// jcmd <pid> Compiler.CodeHeap_Analytics all 4096
// ---------------------------------------------------------------------------------

View File

@ -723,6 +723,9 @@ define_pd_global(uint64_t,MaxRAM, 1ULL*G);
"Print the code cache memory usage each time a method is " \
"compiled") \
\
diagnostic(bool, PrintCodeHeapAnalytics, false, \
"Print code heap usage statistics on exit and on full condition") \
\
diagnostic(bool, PrintStubCode, false, \
"Print generated stub code") \
\

View File

@ -318,8 +318,7 @@ void print_statistics() {
// CodeHeap State Analytics.
// Does also call NMethodSweeper::print(tty)
LogTarget(Trace, codecache) lt;
if (lt.is_enabled()) {
if (PrintCodeHeapAnalytics) {
CompileBroker::print_heapinfo(NULL, "all", "4096"); // details
} else if (PrintMethodFlushingStatistics) {
NMethodSweeper::print(tty);
@ -387,8 +386,7 @@ void print_statistics() {
// CodeHeap State Analytics.
// Does also call NMethodSweeper::print(tty)
LogTarget(Trace, codecache) lt;
if (lt.is_enabled()) {
if (PrintCodeHeapAnalytics) {
CompileBroker::print_heapinfo(NULL, "all", "4096"); // details
} else if (PrintMethodFlushingStatistics) {
NMethodSweeper::print(tty);