stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8134806: Clean up write_ref_field_work

Browse Source 
Remove unnecessary pure virtual decl and default argument values.

Reviewed-by: jwilhelm, tbenson, jmasa
This commit is contained in:
Kim Barrett 2015-09-02 11:41:42 -04:00
parent f55b656f2d
commit 8ebc8387ba
5 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hotspot/src/share/vm/gc/g1/g1SATBCardTableModRefBS.cpp
View File

@ -200,7 +200,7 @@ G1SATBCardTableLoggingModRefBS::write_ref_field_static(void* field,
// Otherwise, log it. // Otherwise, log it.
G1SATBCardTableLoggingModRefBS* g1_bs = G1SATBCardTableLoggingModRefBS* g1_bs =
barrier_set_cast<G1SATBCardTableLoggingModRefBS>(G1CollectedHeap::heap()->barrier_set()); barrier_set_cast<G1SATBCardTableLoggingModRefBS>(G1CollectedHeap::heap()->barrier_set());
g1_bs->write_ref_field_work(field, new_val); g1_bs->write_ref_field_work(field, new_val, false);
} }
void void

6
hotspot/src/share/vm/gc/g1/g1SATBCardTableModRefBS.hpp
View File

@ -147,6 +147,10 @@ class G1SATBCardTableLoggingModRefBS: public G1SATBCardTableModRefBS {
private: private:
G1SATBCardTableLoggingModRefBSChangedListener _listener; G1SATBCardTableLoggingModRefBSChangedListener _listener;
DirtyCardQueueSet& _dcqs; DirtyCardQueueSet& _dcqs;
protected:
virtual void write_ref_field_work(void* field, oop new_val, bool release);
public: public:
static size_t compute_size(size_t mem_region_size_in_words) { static size_t compute_size(size_t mem_region_size_in_words) {
size_t number_of_slots = (mem_region_size_in_words / card_size_in_words); size_t number_of_slots = (mem_region_size_in_words / card_size_in_words);
@ -165,8 +169,6 @@ class G1SATBCardTableLoggingModRefBS: public G1SATBCardTableModRefBS {
virtual void resize_covered_region(MemRegion new_region) { ShouldNotReachHere(); } virtual void resize_covered_region(MemRegion new_region) { ShouldNotReachHere(); }
void write_ref_field_work(void* field, oop new_val, bool release = false);
// Can be called from static contexts. // Can be called from static contexts.
static void write_ref_field_static(void* field, oop new_val); static void write_ref_field_static(void* field, oop new_val);

2
hotspot/src/share/vm/gc/shared/barrierSet.hpp
View File

@ -145,7 +145,7 @@ public:
// ...then the post-write version. // ...then the post-write version.
inline void write_ref_field(void* field, oop new_val, bool release = false); inline void write_ref_field(void* field, oop new_val, bool release = false);
protected: protected:
virtual void write_ref_field_work(void* field, oop new_val, bool release = false) = 0; virtual void write_ref_field_work(void* field, oop new_val, bool release) = 0;
public: public:
// Invoke the barrier, if any, necessary when writing the "bytes"-byte // Invoke the barrier, if any, necessary when writing the "bytes"-byte

2
hotspot/src/share/vm/gc/shared/cardTableModRefBS.hpp
View File

@ -183,7 +183,7 @@ protected:
// these functions here for performance. // these functions here for performance.
void write_ref_field_work(oop obj, size_t offset, oop newVal); void write_ref_field_work(oop obj, size_t offset, oop newVal);
virtual void write_ref_field_work(void* field, oop newVal, bool release = false); virtual void write_ref_field_work(void* field, oop newVal, bool release);
public: public:
bool has_write_ref_array_opt() { return true; } bool has_write_ref_array_opt() { return true; }

1
hotspot/src/share/vm/gc/shared/modRefBarrierSet.hpp
View File

@ -60,7 +60,6 @@ protected:
: BarrierSet(fake_rtti.add_tag(BarrierSet::ModRef)) { } : BarrierSet(fake_rtti.add_tag(BarrierSet::ModRef)) { }
~ModRefBarrierSet() { } ~ModRefBarrierSet() { }
virtual void write_ref_field_work(void* field, oop new_val, bool release = false) = 0;
public: public:
void write_prim_field(HeapWord* field, size_t bytes, void write_prim_field(HeapWord* field, size_t bytes,
juint val1, juint val2) {} juint val1, juint val2) {}