stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8236596: HttpClient leaves HTTP/2 sockets in CLOSE_WAIT, when using proxy tunnel

Browse Source 
Changes Http2ClientImpl::stop to close the TCP connection after sending out the GOAWAY frame.

Reviewed-by: chegar
This commit is contained in:
Daniel Fuchs 2020-01-24 17:57:41 +00:00
parent 4fdcb47304
commit 9085b7bdc7
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java
View File

@ -25,6 +25,7 @@
package jdk.internal.net.http;
import java.io.EOFException;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.net.ConnectException;
@ -186,14 +187,18 @@ class Http2ClientImpl {
}
}
private EOFException STOPPED;
void stop() {
if (debug.on()) debug.log("stopping");
STOPPED = new EOFException("HTTP/2 client stopped");
STOPPED.setStackTrace(new StackTraceElement[0]);
connections.values().forEach(this::close);
connections.clear();
}
private void close(Http2Connection h2c) {
try { h2c.close(); } catch (Throwable t) {}
try { h2c.shutdown(STOPPED); } catch (Throwable t) {}
}
HttpClientImpl client() {