stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8308335: JFR: Remove @Experimental from Virtual Threads events

Browse Source 
Reviewed-by: alanb, mgronlun
This commit is contained in:
Erik Gahlin 2023-05-25 12:19:38 +00:00
parent 7e2e05d836
commit 90e57fd5a9
5 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadEndEvent.java
View File

@ -26,7 +26,6 @@
package jdk.jfr.events;
import jdk.jfr.Category;
import jdk.jfr.Experimental;
import jdk.jfr.Label;
import jdk.jfr.Name;
import jdk.jfr.internal.MirrorEvent;
@ -35,7 +34,6 @@ import jdk.jfr.internal.MirrorEvent;
@Label("Virtual Thread End")
@Name("jdk.VirtualThreadEnd")
@MirrorEvent(className = "jdk.internal.event.VirtualThreadEndEvent")
@Experimental
public final class VirtualThreadEndEvent extends AbstractJDKEvent {
@Label("Thread Id")

2
src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadPinnedEvent.java
View File

@ -26,7 +26,6 @@
package jdk.jfr.events;
import jdk.jfr.Category;
import jdk.jfr.Experimental;
import jdk.jfr.Label;
import jdk.jfr.Name;
import jdk.jfr.internal.MirrorEvent;
@ -35,6 +34,5 @@ import jdk.jfr.internal.MirrorEvent;
@Label("Virtual Thread Pinned")
@Name("jdk.VirtualThreadPinned")
@MirrorEvent(className = "jdk.internal.event.VirtualThreadPinnedEvent")
@Experimental
public final class VirtualThreadPinnedEvent extends AbstractJDKEvent {
}

2
src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadStartEvent.java
View File

@ -26,7 +26,6 @@
package jdk.jfr.events;
import jdk.jfr.Category;
import jdk.jfr.Experimental;
import jdk.jfr.Label;
import jdk.jfr.Name;
import jdk.jfr.internal.MirrorEvent;
@ -35,7 +34,6 @@ import jdk.jfr.internal.MirrorEvent;
@Label("Virtual Thread Start")
@Name("jdk.VirtualThreadStart")
@MirrorEvent(className = "jdk.internal.event.VirtualThreadStartEvent")
@Experimental
public final class VirtualThreadStartEvent extends AbstractJDKEvent {
@Label("Thread Id")

2
src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadSubmitFailedEvent.java
View File

@ -27,7 +27,6 @@ package jdk.jfr.events;
import jdk.jfr.Category;
import jdk.jfr.Description;
import jdk.jfr.Experimental;
import jdk.jfr.Label;
import jdk.jfr.Name;
import jdk.jfr.internal.MirrorEvent;
@ -37,7 +36,6 @@ import jdk.jfr.internal.MirrorEvent;
@Name("jdk.VirtualThreadSubmitFailed")
@Description("Submit of task for virtual thread failed")
@MirrorEvent(className = "jdk.internal.event.VirtualThreadSubmitFailedEvent")
@Experimental
public final class VirtualThreadSubmitFailedEvent extends AbstractJDKEvent {
@Label("Thread Id")

16
test/jdk/jdk/jfr/event/metadata/TestLookForUntestedEvents.java
View File

@ -77,6 +77,9 @@ public class TestLookForUntestedEvents {
"ContainerConfiguration", "ContainerCPUUsage", "ContainerCPUThrottling",
"ContainerMemoryUsage", "ContainerIOUsage")
);
// These events are tested in test/jdk/java/lang/Thread/virtual/JfrEvents.java
private static final Set<String> coveredVirtualThreadEvents = Set.of(
"VirtualThreadPinned", "VirtualThreadSubmitFailed");
// This is a "known failure list" for this test.
// NOTE: if the event is not covered, a bug should be open, and bug number
@ -85,16 +88,8 @@ public class TestLookForUntestedEvents {
);
// Experimental events
private static final Set<String> experimentalEvents = new HashSet<>(
Arrays.asList(
"Flush",
"SyncOnValueBasedClass",
"VirtualThreadStart",
"VirtualThreadEnd",
"VirtualThreadPinned",
"VirtualThreadSubmitFailed")
);
private static final Set<String> experimentalEvents = Set.of(
"Flush", "SyncOnValueBasedClass");
public static void main(String[] args) throws Exception {
for (EventType type : FlightRecorder.getFlightRecorder().getEventTypes()) {
@ -127,6 +122,7 @@ public class TestLookForUntestedEvents {
// Account for hard-to-test, experimental and GC tested events
eventsNotCoveredByTest.removeAll(hardToTestEvents);
eventsNotCoveredByTest.removeAll(coveredGcEvents);
eventsNotCoveredByTest.removeAll(coveredVirtualThreadEvents);
eventsNotCoveredByTest.removeAll(coveredContainerEvents);
eventsNotCoveredByTest.removeAll(knownNotCoveredEvents);