stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8161552: Test issue: VM init failed: GC triggered before VM initialization completed. Try increasing NewSize, current value 768K

Browse Source 
Reviewed-by: tschatzl, jmasa, zmajo
This commit is contained in:
Dmitry Fazunenko 2016-07-21 17:12:35 +04:00
parent 4f554660a0
commit 92110548e8
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
hotspot/test/gc/TestSmallHeap.java
View File

@ -34,7 +34,7 @@
* @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI TestSmallHeap * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI TestSmallHeap
*/ */
/* Note: It would be nice to verify the minimal supported heap size (2m) here, /* Note: It would be nice to verify the minimal supported heap size here,
* but we align the heap size based on the card table size. And the card table * but we align the heap size based on the card table size. And the card table
* size is aligned based on the minimal pages size provided by the os. This * size is aligned based on the minimal pages size provided by the os. This
* means that on most platforms, where the minimal page size is 4k, we get a * means that on most platforms, where the minimal page size is 4k, we get a
@ -43,14 +43,18 @@
* we get a minimal heap size of 32m. We never use large pages for the card table. * we get a minimal heap size of 32m. We never use large pages for the card table.
* *
* There is also no check in the VM for verifying that the maximum heap size * There is also no check in the VM for verifying that the maximum heap size
* is larger than the supported minimal heap size. This means that specifying * is larger than the supported minimal heap size.
* -Xmx1m on the command line is fine but will give a heap of 2m (or 4m or 32m).
* *
* To work around these rather strange behaviors this test uses -Xmx2m but then * To work around these behaviors this test uses -Xmx4m but then
* calculates what the expected heap size should be. The calculation is a * calculates what the expected heap size should be. The calculation is a
* simplified version of the code in the VM. We assume that the card table will * simplified version of the code in the VM. We assume that the card table will
* use one page. Each byte in the card table corresponds to 512 bytes on the heap. * use one page. Each byte in the card table corresponds to 512 bytes on the heap.
* So, the expected heap size is page_size * 512. * So, the expected heap size is page_size * 512.
*
* There is no formal requirement for the minimal value of the maximum heap size
* the VM should support. In most cases the VM could start with -Xmx2m.
* But with 2m limit GC could be triggered before VM initialization completed.
* Therefore we start the VM with 4M heap.
*/ */
import jdk.test.lib.Asserts; import jdk.test.lib.Asserts;
@ -79,9 +83,10 @@ public class TestSmallHeap {
} }
private static void verifySmallHeapSize(String gc, long expectedMaxHeap) throws Exception { private static void verifySmallHeapSize(String gc, long expectedMaxHeap) throws Exception {
long minMaxHeap = 4 * 1024 * 1024;
LinkedList<String> vmOptions = new LinkedList<>(); LinkedList<String> vmOptions = new LinkedList<>();
vmOptions.add(gc); vmOptions.add(gc);
vmOptions.add("-Xmx2m"); vmOptions.add("-Xmx" + minMaxHeap);
vmOptions.add("-XX:+PrintFlagsFinal"); vmOptions.add("-XX:+PrintFlagsFinal");
vmOptions.add(VerifyHeapSize.class.getName()); vmOptions.add(VerifyHeapSize.class.getName());
@ -89,6 +94,7 @@ public class TestSmallHeap {
OutputAnalyzer analyzer = new OutputAnalyzer(pb.start()); OutputAnalyzer analyzer = new OutputAnalyzer(pb.start());
analyzer.shouldHaveExitValue(0); analyzer.shouldHaveExitValue(0);
expectedMaxHeap = Math.max(expectedMaxHeap, minMaxHeap);
long maxHeapSize = Long.parseLong(analyzer.firstMatch("MaxHeapSize.+=\\s+(\\d+)",1)); long maxHeapSize = Long.parseLong(analyzer.firstMatch("MaxHeapSize.+=\\s+(\\d+)",1));
long actualHeapSize = Long.parseLong(analyzer.firstMatch(VerifyHeapSize.actualMsg + "(\\d+)",1)); long actualHeapSize = Long.parseLong(analyzer.firstMatch(VerifyHeapSize.actualMsg + "(\\d+)",1));
Asserts.assertEQ(maxHeapSize, expectedMaxHeap); Asserts.assertEQ(maxHeapSize, expectedMaxHeap);

2
hotspot/test/gc/arguments/TestMaxHeapSizeTools.java
View File

@ -106,7 +106,6 @@ class TestMaxHeapSizeTools {
} }
public static void checkGenMaxHeapErgo(String gcflag) throws Exception { public static void checkGenMaxHeapErgo(String gcflag) throws Exception {
TestMaxHeapSizeTools.checkGenMaxHeapSize(gcflag, 3);
TestMaxHeapSizeTools.checkGenMaxHeapSize(gcflag, 4); TestMaxHeapSizeTools.checkGenMaxHeapSize(gcflag, 4);
TestMaxHeapSizeTools.checkGenMaxHeapSize(gcflag, 5); TestMaxHeapSizeTools.checkGenMaxHeapSize(gcflag, 5);
} }
@ -132,7 +131,6 @@ class TestMaxHeapSizeTools {
} }
private static void checkValidInitialMaxHeapCombinations(String gcflag) throws Exception { private static void checkValidInitialMaxHeapCombinations(String gcflag) throws Exception {
expectValid(new String[] { gcflag, "-XX:MaxHeapSize=2048K", "-version" });
expectValid(new String[] { gcflag, "-XX:InitialHeapSize=4M", "-XX:MaxHeapSize=8M", "-version" }); expectValid(new String[] { gcflag, "-XX:InitialHeapSize=4M", "-XX:MaxHeapSize=8M", "-version" });
expectValid(new String[] { gcflag, "-XX:MaxHeapSize=8M", "-XX:InitialHeapSize=4M", "-version" }); expectValid(new String[] { gcflag, "-XX:MaxHeapSize=8M", "-XX:InitialHeapSize=4M", "-version" });
expectValid(new String[] { gcflag, "-XX:MaxHeapSize=4M", "-XX:InitialHeapSize=4M", "-version" }); expectValid(new String[] { gcflag, "-XX:MaxHeapSize=4M", "-XX:InitialHeapSize=4M", "-version" });