From 99de9bb83ff70fe81c89751516a86a94c8f552be Mon Sep 17 00:00:00 2001 From: Magnus Ihse Bursie Date: Mon, 23 Oct 2023 11:26:39 +0000 Subject: [PATCH] 8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039 Reviewed-by: erikj --- make/RunTestsPrebuilt.gmk | 4 ++-- make/RunTestsPrebuiltSpec.gmk | 2 ++ make/autoconf/lib-tests.m4 | 9 ++++----- make/autoconf/spec.gmk.in | 5 +++-- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/make/RunTestsPrebuilt.gmk b/make/RunTestsPrebuilt.gmk index 363644ecf0a..ae14b1e5336 100644 --- a/make/RunTestsPrebuilt.gmk +++ b/make/RunTestsPrebuilt.gmk @@ -122,7 +122,7 @@ $(eval $(call SetupVariable,JT_HOME)) $(eval $(call SetupVariable,JDK_IMAGE_DIR,$(OUTPUTDIR)/images/jdk)) $(eval $(call SetupVariable,TEST_IMAGE_DIR,$(OUTPUTDIR)/images/test)) $(eval $(call SetupVariable,SYMBOLS_IMAGE_DIR,$(OUTPUTDIR)/images/symbols,NO_CHECK)) -$(eval $(call SetupVariable,JTREG_JAVA,$(BOOT_JDK)/bin/java)) +$(eval $(call SetupVariable,JTREG_JDK,$(BOOT_JDK))) # Provide default values for tools that we need $(eval $(call SetupVariable,MAKE,make,NO_CHECK)) @@ -249,7 +249,7 @@ $(call CreateNewSpec, $(NEW_SPEC), \ TOPDIR := $(TOPDIR), \ OUTPUTDIR := $(OUTPUTDIR), \ BOOT_JDK := $(BOOT_JDK), \ - JTREG_JAVA := $(FIXPATH) $(JTREG_JAVA), \ + JTREG_JDK := $(JTREG_JDK), \ JT_HOME := $(JT_HOME), \ JDK_IMAGE_DIR := $(JDK_IMAGE_DIR), \ JCOV_IMAGE_DIR := $(JCOV_IMAGE_DIR), \ diff --git a/make/RunTestsPrebuiltSpec.gmk b/make/RunTestsPrebuiltSpec.gmk index 585fd24fda3..7fcaf56ff52 100644 --- a/make/RunTestsPrebuiltSpec.gmk +++ b/make/RunTestsPrebuiltSpec.gmk @@ -124,6 +124,8 @@ JAR := $(FIXPATH) $(JAR_CMD) JLINK := $(FIXPATH) $(JLINK_CMD) JMOD := $(FIXPATH) $(JMOD_CMD) +JTREG_JAVA := $(FIXPATH) $(JTREG_JDK)/bin/java $(JAVA_FLAGS_BIG) $(JAVA_FLAGS) + BUILD_JAVA := $(JDK_IMAGE_DIR)/bin/JAVA ################################################################################ # Some common tools. Assume most common name and no path. diff --git a/make/autoconf/lib-tests.m4 b/make/autoconf/lib-tests.m4 index 5c03d433c38..be099e50a04 100644 --- a/make/autoconf/lib-tests.m4 +++ b/make/autoconf/lib-tests.m4 @@ -251,11 +251,10 @@ AC_DEFUN_ONCE([LIB_TESTS_SETUP_JTREG], AC_MSG_RESULT([no, using BOOT_JDK]) fi - JTREG_JAVA="$JTREG_JDK/bin/java" - UTIL_FIXUP_PATH(JTREG_JAVA) - JTREG_JAVA="$FIXPATH $JTREG_JAVA" - AC_SUBST([JTREG_JAVA]) - + UTIL_FIXUP_PATH(JTREG_JDK) + AC_SUBST([JTREG_JDK]) + # For use in the configure script + JTREG_JAVA="$FIXPATH $JTREG_JDK/bin/java" # Verify jtreg version if test "x$JT_HOME" != x; then diff --git a/make/autoconf/spec.gmk.in b/make/autoconf/spec.gmk.in index 1f2accf3a67..2b7a7b8d1af 100644 --- a/make/autoconf/spec.gmk.in +++ b/make/autoconf/spec.gmk.in @@ -666,8 +666,6 @@ JAVA_FLAGS_SMALL:=@JAVA_FLAGS_SMALL@ BUILDJDK_JAVA_FLAGS_SMALL:=@BUILDJDK_JAVA_FLAGS_SMALL@ JAVA_TOOL_FLAGS_SMALL:=@JAVA_TOOL_FLAGS_SMALL@ -JTREG_JAVA:=@JTREG_JAVA@ - # The *_CMD variables are defined separately to be easily overridden in bootcycle-spec.gmk # for bootcycle-images build. Make sure to keep them in sync. Do not use the *_CMD # versions of the variables directly. @@ -687,6 +685,9 @@ JAR = $(JAR_CMD) JLINK = $(JLINK_CMD) JMOD = $(JMOD_CMD) +JTREG_JDK := @JTREG_JDK@ +JTREG_JAVA = @FIXPATH@ $(JTREG_JDK)/bin/java $(JAVA_FLAGS_BIG) $(JAVA_FLAGS) + BUILD_JAVA_FLAGS := @BOOTCYCLE_JVM_ARGS_BIG@ BUILD_JAVA=@FIXPATH@ $(BUILD_JDK)/bin/java $(BUILD_JAVA_FLAGS) BUILD_JAVAC=@FIXPATH@ $(BUILD_JDK)/bin/javac