stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8210731: PropertiesParser does not produce reproducible output

Browse Source 
Reviewed-by: mchung, jjg, erikj
This commit is contained in:
Magnus Ihse Bursie 2018-09-14 09:16:51 +02:00
parent acb7acc64f
commit 99eee041ba
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
make/langtools/tools/propertiesparser/PropertiesParser.java
View File

@ -30,7 +30,7 @@ import propertiesparser.gen.ClassGenerator;
import java.io.File; import java.io.File;
import java.io.PrintStream; import java.io.PrintStream;
import java.util.HashMap; import java.util.TreeMap;
import java.util.Map; import java.util.Map;
/** Translates a .properties file into a .java file containing an enum-like Java class /** Translates a .properties file into a .java file containing an enum-like Java class
@ -96,12 +96,13 @@ public class PropertiesParser {
} }
private Map<String, String> parseOptions(String args[]) { private Map<String, String> parseOptions(String args[]) {
Map<String, String> optionsMap = new HashMap<>(args.length); /* Use TreeMap to guarantee stable forEach iteration */
Map<String, String> optionsMap = new TreeMap<>();
for ( int i = 0; i < args.length ; i++ ) { for ( int i = 0; i < args.length ; i++ ) {
if ( "-compile".equals(args[i]) && i+2 < args.length ) { if ( "-compile".equals(args[i]) && i+2 < args.length ) {
optionsMap.put(args[++i], args[++i]); optionsMap.put(args[++i], args[++i]);
} else { } else {
return new HashMap<>(); return new TreeMap<>();
} }
} }
return optionsMap; return optionsMap;