stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

7110428: Crash during HeapDump operation

Browse Source 
Reviewed-by: ysr, dholmes
This commit is contained in:
Poonam Bajaj 2011-11-16 16:27:29 -08:00
parent ed1e70076b
commit 9b428e449c
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hotspot/src/share/vm/services/heapDumper.cpp
View File

@ -27,6 +27,7 @@
#include "classfile/systemDictionary.hpp" #include "classfile/systemDictionary.hpp"
#include "classfile/vmSymbols.hpp" #include "classfile/vmSymbols.hpp"
#include "gc_implementation/shared/vmGCOperations.hpp" #include "gc_implementation/shared/vmGCOperations.hpp"
#include "memory/gcLocker.inline.hpp"
#include "memory/genCollectedHeap.hpp" #include "memory/genCollectedHeap.hpp"
#include "memory/universe.hpp" #include "memory/universe.hpp"
#include "oops/objArrayKlass.hpp" #include "oops/objArrayKlass.hpp"
@ -1709,11 +1710,16 @@ void VM_HeapDumper::doit() {
HandleMark hm; HandleMark hm;
CollectedHeap* ch = Universe::heap(); CollectedHeap* ch = Universe::heap();
ch->ensure_parsability(false); // must happen, even if collection does
// not happen (e.g. due to GC_locker)
if (_gc_before_heap_dump) { if (_gc_before_heap_dump) {
ch->collect_as_vm_thread(GCCause::_heap_dump); if (GC_locker::is_active()) {
warning("GC locker is held; pre-heapdump GC was skipped");
} else { } else {
// make the heap parsable (no need to retire TLABs) ch->collect_as_vm_thread(GCCause::_heap_dump);
ch->ensure_parsability(false); }
} }
// At this point we should be the only dumper active, so // At this point we should be the only dumper active, so