stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8253299: Manifest bytes are read twice when verifying a signed JAR

Browse Source 
Reviewed-by: redestad, lancea, alanb
This commit is contained in:
Hai-May Chao 2020-11-19 17:22:59 +00:00 committed by Lance Andersen
parent 580f22ccb7
commit 9bb82232fa
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/java.base/share/classes/java/util/jar/JarFile.java
View File

@ -739,6 +739,7 @@ public class JarFile extends ZipFile {
List<String> names = JUZFA.getManifestAndSignatureRelatedFiles(this);
for (String name : names) {
JarEntry e = getJarEntry(name);
byte[] b;
if (e == null) {
throw new JarException("corrupted jar file");
}
@ -746,7 +747,11 @@ public class JarFile extends ZipFile {
mev = new ManifestEntryVerifier
(getManifestFromReference());
}
byte[] b = getBytes(e);
if (name.equals(MANIFEST_NAME)) {
b = jv.manifestRawBytes;
} else {
b = getBytes(e);
}
if (b != null && b.length > 0) {
jv.beginEntry(e, mev);
jv.update(b.length, b, 0, b.length, mev);