stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8288706: Unused parameter 'boolean newln' in method java.lang.VersionProps#print(boolean, boolean)

Browse Source 
Reviewed-by: iris, alanb, rriggs
This commit is contained in:
Lance Andersen 2022-07-06 15:37:23 +00:00
parent dfb24ae4b7
commit 9f37ba44b8
2 changed files with 6 additions and 18 deletions
src/java.base/share
classes/java/lang
VersionProps.java.template
native/libjli
java.c

16
src/java.base/share/classes/java/lang/VersionProps.java.template

@ -186,25 +186,13 @@ class VersionProps {
}
}
/**
* In case you were wondering this method is called by java -version.
*/
public static void print(boolean err) {
print(err, false);
}
/**
* This is the same as print except that it adds an extra line-feed
* at the end, typically used by the -showversion in the launcher
*/
public static void println(boolean err) {
print(err, true);
}
/**
* Print version info.
* In case you were wondering this method is called by java -version.
*/
private static void print(boolean err, boolean newln) {
private static void print(boolean err) {
PrintStream ps = err ? System.err : System.out;
/* First line: platform version. */

8
src/java.base/share/native/libjli/java.c

@ -123,7 +123,7 @@ static void TranslateApplicationArgs(int jargc, const char **jargv, int *pargc,
static jboolean AddApplicationOptions(int cpathc, const char **cpathv);
static void SetApplicationClassPath(const char**);
static void PrintJavaVersion(JNIEnv *env, jboolean extraLF);
static void PrintJavaVersion(JNIEnv *env);
static void PrintUsage(JNIEnv* env, jboolean doXUsage);
static void ShowSettings(JNIEnv* env, char *optString);
static void ShowResolvedModules(JNIEnv* env);
@ -441,7 +441,7 @@ JavaMain(void* _args)
}
if (printVersion || showVersion) {
PrintJavaVersion(env, showVersion);
PrintJavaVersion(env);
CHECK_EXCEPTION_LEAVE(0);
if (printVersion) {
LEAVE();
@ -1804,7 +1804,7 @@ static void SetJavaLauncherProp() {
* Prints the version information from the java.version and other properties.
*/
static void
PrintJavaVersion(JNIEnv *env, jboolean extraLF)
PrintJavaVersion(JNIEnv *env)
{
jclass ver;
jmethodID print;
@ -1812,7 +1812,7 @@ PrintJavaVersion(JNIEnv *env, jboolean extraLF)
NULL_CHECK(ver = FindBootStrapClass(env, "java/lang/VersionProps"));
NULL_CHECK(print = (*env)->GetStaticMethodID(env,
ver,
(extraLF == JNI_TRUE) ? "println" : "print",
"print",
"(Z)V"
)
);