stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8046025: AccessorProperty.getGetter is not threadsafe

Browse Source 
Reviewed-by: jlaskey, lagergren
This commit is contained in:
Attila Szegedi 2014-06-09 16:00:06 +02:00
parent eab7ad0813
commit 9f8c1be305
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
nashorn/src/jdk/nashorn/internal/runtime/AccessorProperty.java
View File

@ -550,8 +550,13 @@ public class AccessorProperty extends Property {
"invalid getter type " + type + " for " + getKey();
//all this does is add a return value filter for object fields only
if (GETTER_CACHE[i] == null) {
GETTER_CACHE[i] = debug(
final MethodHandle[] getterCache = GETTER_CACHE;
final MethodHandle cachedGetter = getterCache[i];
final MethodHandle getter;
if (cachedGetter != null) {
getter = cachedGetter;
} else {
getter = debug(
createGetter(
getCurrentType(),
type,
@ -561,9 +566,10 @@ public class AccessorProperty extends Property {
getCurrentType(),
type,
"get");
getterCache[i] = getter;
}
assert GETTER_CACHE[i].type().returnType() == type && GETTER_CACHE[i].type().parameterType(0) == Object.class;
return GETTER_CACHE[i];
assert getter.type().returnType() == type && getter.type().parameterType(0) == Object.class;
return getter;
}
@Override