stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8261791: (sctp) handleSendFailed in SctpChannelImpl.c potential leaks

Browse Source 
Reviewed-by: chegar, alanb
This commit is contained in:
Matthias Baesken 2021-02-17 13:49:30 +00:00
parent 9ba2b71a61
commit a0658795cf
1 changed files with 10 additions and 2 deletions

12
src/jdk.sctp/unix/native/libsctp/SctpChannelImpl.c

@ -229,7 +229,10 @@ void handleSendFailed
msg->msg_iovlen = 1;
bufferObj = (*env)->NewDirectByteBuffer(env, addressP, dataLength);
CHECK_NULL(bufferObj);
if (bufferObj == NULL) {
free(addressP);
return;
}
alreadyRead = read - dataOffset;
if (alreadyRead > 0) {
@ -243,12 +246,14 @@ void handleSendFailed
if (remaining > 0) {
if ((rv = recvmsg(fd, msg, 0)) < 0) {
free(addressP);
handleSocketError(env, errno);
return;
}
if (rv != (dataLength - alreadyRead) || !(msg->msg_flags & MSG_EOR)) {
//TODO: assert false: "should not reach here";
free(addressP);
return;
}
// TODO: Set and document (in API) buffers position.
@ -258,7 +263,10 @@ void handleSendFailed
/* create SendFailed */
resultObj = (*env)->NewObject(env, ssf_class, ssf_ctrID, ssf->ssf_assoc_id,
isaObj, bufferObj, ssf->ssf_error, sri->sinfo_stream);
CHECK_NULL(resultObj);
if (resultObj == NULL) {
if (bufferObj != NULL) free(addressP);
return;
}
(*env)->SetObjectField(env, resultContainerObj, src_valueID, resultObj);
(*env)->SetIntField(env, resultContainerObj, src_typeID,
sun_nio_ch_sctp_ResultContainer_SEND_FAILED);