From 892dcc25fc7d9ad19e743584786d2d8409b89868 Mon Sep 17 00:00:00 2001 From: Kelly O'Hair Date: Wed, 4 Jan 2012 17:42:25 -0800 Subject: [PATCH 1/2] 7127104: Build issue with prtconf and zones, also using := to avoid extra execs Reviewed-by: katleman --- jdk/make/common/shared/Platform.gmk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jdk/make/common/shared/Platform.gmk b/jdk/make/common/shared/Platform.gmk index 97cbc6ee785..a64c2b46ef6 100644 --- a/jdk/make/common/shared/Platform.gmk +++ b/jdk/make/common/shared/Platform.gmk @@ -147,8 +147,8 @@ ifeq ($(SYSTEM_UNAME), SunOS) endif # Suffix for file bundles used in previous release BUNDLE_FILE_SUFFIX=.tar - # How much RAM does this machine have: - MB_OF_MEMORY=$(shell /usr/sbin/prtconf | fgrep 'Memory size:' | expand | cut -d' ' -f3) + # How much RAM does this machine have (zones send an error to stderr): + MB_OF_MEMORY:=$(shell /usr/sbin/prtconf 2>/dev/null | fgrep 'Memory size:' | expand | cut -d' ' -f3) endif # Platform settings specific to Linux From 467c036ccf659cc664437be97f971c834a98da06 Mon Sep 17 00:00:00 2001 From: Jonathan Lu Date: Mon, 9 Jan 2012 09:18:37 -0800 Subject: [PATCH 2/2] 7128320: Fix freetype sanity check to make it more generic Reviewed-by: luchsh, katleman --- jdk/make/common/Defs-linux.gmk | 1 - jdk/make/common/Defs-solaris.gmk | 1 - jdk/make/common/Defs-windows.gmk | 1 - jdk/make/common/Demo.gmk | 7 +++++-- jdk/make/tools/freetypecheck/Makefile | 21 +++++++++++---------- 5 files changed, 16 insertions(+), 15 deletions(-) diff --git a/jdk/make/common/Defs-linux.gmk b/jdk/make/common/Defs-linux.gmk index d20efc97180..026b18004d2 100644 --- a/jdk/make/common/Defs-linux.gmk +++ b/jdk/make/common/Defs-linux.gmk @@ -72,7 +72,6 @@ FDDLIBM_SUFFIX = a SCRIPT_SUFFIX = # CC compiler object code output directive flag value CC_OBJECT_OUTPUT_FLAG = -o #trailing blank required! -CC_PROGRAM_OUTPUT_FLAG = -o #trailing blank required! # Default OBJCOPY comes from GNU Binutils on Linux: DEF_OBJCOPY=/usr/bin/objcopy diff --git a/jdk/make/common/Defs-solaris.gmk b/jdk/make/common/Defs-solaris.gmk index 666cdc12ef2..aae69291a5f 100644 --- a/jdk/make/common/Defs-solaris.gmk +++ b/jdk/make/common/Defs-solaris.gmk @@ -72,7 +72,6 @@ FDDLIBM_SUFFIX = a SCRIPT_SUFFIX = # CC compiler object code output directive flag value CC_OBJECT_OUTPUT_FLAG = -o #trailing blank required! -CC_PROGRAM_OUTPUT_FLAG = -o #trailing blank required! ifdef ENABLE_FULL_DEBUG_SYMBOLS # Only check for Full Debug Symbols support on Solaris if it is diff --git a/jdk/make/common/Defs-windows.gmk b/jdk/make/common/Defs-windows.gmk index d04d60a7924..c23d0244906 100644 --- a/jdk/make/common/Defs-windows.gmk +++ b/jdk/make/common/Defs-windows.gmk @@ -36,7 +36,6 @@ include $(JDK_MAKE_SHARED_DIR)/Defs.gmk # CC compiler object code output directive flag value CC_OBJECT_OUTPUT_FLAG = -Fo -CC_PROGRAM_OUTPUT_FLAG = -Fe # The suffix applied to the library name for FDLIBM FDDLIBM_SUFFIX = lib diff --git a/jdk/make/common/Demo.gmk b/jdk/make/common/Demo.gmk index 429c4e546c9..c6cf41d6b3f 100644 --- a/jdk/make/common/Demo.gmk +++ b/jdk/make/common/Demo.gmk @@ -319,9 +319,12 @@ $(DEMO_LIBRARY): $(DEMO_FULL_OBJECTS) @$(prep-target) ifeq ($(PLATFORM),windows) $(RC) $(RC_FLAGS) $(CC_OBJECT_OUTPUT_FLAG)$(DEMO_VERSION_INFO) $(VERSIONINFO_RESOURCE) - endif - $(LINK.demo) $(SHARED_LIBRARY_FLAG) $(CC_PROGRAM_OUTPUT_FLAG)$@ \ + $(LINK.demo) $(SHARED_LIBRARY_FLAG) -Fe$@ \ $(DEMO_FULL_OBJECTS) $(LDLIBS.demo) + else + $(LINK.demo) $(SHARED_LIBRARY_FLAG) -o $@ \ + $(DEMO_FULL_OBJECTS) $(LDLIBS.demo) + endif @$(call binary_file_verification,$@) # Generation of any javah include file, make sure objects are dependent on it diff --git a/jdk/make/tools/freetypecheck/Makefile b/jdk/make/tools/freetypecheck/Makefile index dcacde5362e..101542fea82 100644 --- a/jdk/make/tools/freetypecheck/Makefile +++ b/jdk/make/tools/freetypecheck/Makefile @@ -40,18 +40,19 @@ ifeq ($(PLATFORM), windows) FT_OPTIONS = /nologo /c FREETYPE_DLL = $(FREETYPE_LIB_PATH)/freetype.dll FT_LD_OPTIONS = $(FREETYPE_LIB_PATH)/freetype.lib -ifdef MT - FT_LD_OPTIONS += /manifest -endif + ifdef MT + FT_LD_OPTIONS += /manifest + endif else FT_OPTIONS = $(CFLAGS) FT_LD_OPTIONS = -L$(FREETYPE_LIB_PATH) # Add runtime lib search path to ensure test will be runnable - ifeq ($(PLATFORM), solaris) - FT_LD_OPTIONS += -R $(FREETYPE_LIB_PATH) -lfreetype - else #linux - FT_LD_OPTIONS += -Wl,-rpath -Wl,$(FREETYPE_LIB_PATH) -lfreetype + ifeq ($(PLATFORM), linux) + FT_LD_OPTIONS += -Wl,-rpath -Wl,$(FREETYPE_LIB_PATH) + else # other unix + FT_LD_OPTIONS += -R $(FREETYPE_LIB_PATH) endif + FT_LD_OPTIONS += -lfreetype endif FT_OPTIONS += -I$(FREETYPE_HEADERS_PATH) FT_OPTIONS += -I$(FREETYPE_HEADERS_PATH)/freetype2 @@ -70,12 +71,12 @@ ifeq ($(PLATFORM), windows) $(CC) $(FT_OPTIONS) $(CC_OBJECT_OUTPUT_FLAG)$(FT_OBJ) $< $(LINK) $(FT_LD_OPTIONS) /OUT:$(FT_TEST) $(FT_OBJ) $(CP) $(FREETYPE_DLL) $(@D)/ -ifdef MT + ifdef MT $(CP) $(MSVCRNN_DLL_PATH)/$(MSVCRNN_DLL) $(@D)/ $(MT) /manifest $(FT_TEST).manifest /outputresource:$(FT_TEST);#1 -endif + endif else - @$(CC) $(FT_OPTIONS) $(CC_PROGRAM_OUTPUT_FLAG)$@ $< $(FT_LD_OPTIONS) + @$(CC) $(FT_OPTIONS) -o $@ $< $(FT_LD_OPTIONS) endif else