stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8224161: Check.checkOverrideClashes n^2 algorithm

Browse Source 
Caching type's members in Check.checkOverrideClashes to improve performance.

Reviewed-by: mcimadamore, jlahoda
This commit is contained in:
Ron Shapiro 2019-06-13 08:42:49 +02:00
parent 0f42d9870e
commit a7a5e567df
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java
View File

@ -2421,7 +2421,9 @@ public class Check {
List<MethodSymbol> potentiallyAmbiguousList = List.nil(); List<MethodSymbol> potentiallyAmbiguousList = List.nil();
boolean overridesAny = false; boolean overridesAny = false;
for (Symbol m1 : types.membersClosure(site, false).getSymbolsByName(sym.name, cf)) { ArrayList<Symbol> symbolsByName = new ArrayList<>();
types.membersClosure(site, false).getSymbolsByName(sym.name, cf).forEach(symbolsByName::add);
for (Symbol m1 : symbolsByName) {
if (!sym.overrides(m1, site.tsym, types, false)) { if (!sym.overrides(m1, site.tsym, types, false)) {
if (m1 == sym) { if (m1 == sym) {
continue; continue;
@ -2439,7 +2441,7 @@ public class Check {
} }
//...check each method m2 that is a member of 'site' //...check each method m2 that is a member of 'site'
for (Symbol m2 : types.membersClosure(site, false).getSymbolsByName(sym.name, cf)) { for (Symbol m2 : symbolsByName) {
if (m2 == m1) continue; if (m2 == m1) continue;
//if (i) the signature of 'sym' is not a subsignature of m1 (seen as //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
//a member of 'site') and (ii) m1 has the same erasure as m2, issue an error //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error