stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8254871: Remove unnecessary string copy in NetworkInterface.c

Browse Source 
Reviewed-by: michaelm
This commit is contained in:
Eric Liu 2020-10-28 02:15:36 +00:00 committed by Nick Gasson
parent acd0e2560c
commit a804c6a6ef
1 changed files with 3 additions and 8 deletions

11
src/java.base/unix/native/libnet/NetworkInterface.c

@ -205,7 +205,6 @@ JNIEXPORT jobject JNICALL Java_java_net_NetworkInterface_getByName0
jboolean isCopy;
const char* name_utf;
char *colonP;
char searchName[IFNAMESIZE];
jobject obj = NULL;
if (name != NULL) {
@ -229,15 +228,11 @@ JNIEXPORT jobject JNICALL Java_java_net_NetworkInterface_getByName0
// search the list of interfaces based on name,
// if it is virtual sub interface search with parent first.
strncpy(searchName, name_utf, IFNAMESIZE);
searchName[IFNAMESIZE - 1] = '\0';
colonP = strchr(searchName, ':');
if (colonP != NULL) {
*colonP = '\0';
}
colonP = strchr(name_utf, ':');
size_t limit = colonP != NULL ? (size_t)(colonP - name_utf) : strlen(name_utf);
curr = ifs;
while (curr != NULL) {
if (strcmp(searchName, curr->name) == 0) {
if (strlen(curr->name) == limit && memcmp(name_utf, curr->name, limit) == 0) {
break;
}
curr = curr->next;