stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8343810: [s390x] is_uimm* methods should take unsigned arguments

Browse Source 
Reviewed-by: lucy
This commit is contained in:
Amit Kumar 2024-11-11 09:32:09 +00:00
parent f12c370d73
commit a93bd9dfdd
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/hotspot/cpu/s390/assembler_s390.hpp
View File

@ -56,24 +56,23 @@ class Immediate {
} }
// Test if x is within signed immediate range for nbits. // Test if x is within signed immediate range for nbits.
static bool is_uimm(int64_t x, unsigned int nbits) { static bool is_uimm(uint64_t x, unsigned int nbits) {
// nbits == 0 --> false // nbits == 0 --> false
// nbits >= 64 --> true // nbits >= 64 --> true
assert(1 <= nbits && nbits < 64, "don't call, use statically known result"); assert(1 <= nbits && nbits < 64, "don't call, use statically known result");
const uint64_t xu = (unsigned long)x;
const uint64_t maxplus1 = 1UL << nbits; const uint64_t maxplus1 = 1UL << nbits;
return xu < maxplus1; // Unsigned comparison. Negative inputs appear to be very large. return x < maxplus1; // Unsigned comparison. Negative inputs appear to be very large.
} }
static bool is_uimm32(int64_t x) { static bool is_uimm32(uint64_t x) {
return is_uimm(x, 32); return is_uimm(x, 32);
} }
static bool is_uimm16(int64_t x) { static bool is_uimm16(uint64_t x) {
return is_uimm(x, 16); return is_uimm(x, 16);
} }
static bool is_uimm12(int64_t x) { static bool is_uimm12(uint64_t x) {
return is_uimm(x, 12); return is_uimm(x, 12);
} }
static bool is_uimm8(int64_t x) { static bool is_uimm8(uint64_t x) {
return is_uimm(x, 8); return is_uimm(x, 8);
} }
}; };