8149334: JSON.parse(JSON.stringify([])).push(10) creates an array containing two elements

Reviewed-by: jlaskey, sundar
This commit is contained in:
Michael Haupt 2016-02-08 17:43:02 +01:00
parent 7415b64ed6
commit ae0daf5c8b
3 changed files with 50 additions and 6 deletions
nashorn
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/arrays
test/script/nosecurity

@ -1,5 +1,5 @@
/*
* Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -81,14 +81,11 @@ public abstract class ArrayData {
}
private ArrayData toRealArrayData() {
return toRealArrayData(0);
return new IntArrayData(0);
}
private ArrayData toRealArrayData(final int index) {
final IntArrayData newData = new IntArrayData(index + 1);
if (index == 0) {
return newData;
}
return new DeletedRangeArrayFilter(newData, 0, index);
}
@ -122,7 +119,7 @@ public abstract class ArrayData {
@Override
public ArrayData convert(final Class<?> type) {
return toRealArrayData(0).convert(type);
return toRealArrayData().convert(type);
}
@Override

@ -0,0 +1,41 @@
/*
* Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* JDK-8149334: JSON.parse(JSON.stringify([])).push(10) creates an array containing two elements
*
* @test
* @run
*/
var a = JSON.parse(JSON.stringify([]))
print(a.length)
a.push(10)
print(a.length)
print(a)
var b = JSON.parse(JSON.stringify([]))
print(b.length)
b.push('ieps')
print(b.length)
print(b)

@ -0,0 +1,6 @@
0
1
10
0
1
ieps