stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)

Browse Source 
Reviewed-by: jpai
This commit is contained in:
Daniel Fuchs 2024-09-02 14:52:04 +00:00
parent 03ba37e60c
commit b1163bcc88
1 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
test/jdk/java/net/httpclient/DependentPromiseActionsTest.java
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -73,6 +73,7 @@ import java.util.concurrent.Executor;
import java.util.concurrent.Executors;
import java.util.concurrent.Flow;
import java.util.concurrent.Semaphore;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.BiPredicate;
@ -112,6 +113,7 @@ public class DependentPromiseActionsTest implements HttpServerAdapters {
static volatile boolean tasksFailed;
static final AtomicLong serverCount = new AtomicLong();
static final AtomicLong clientCount = new AtomicLong();
static final AtomicInteger requestCount = new AtomicInteger();
static final long start = System.nanoTime();
public static String now() {
long now = System.nanoTime() - start;
@ -244,14 +246,17 @@ public class DependentPromiseActionsTest implements HttpServerAdapters {
}
@Test(dataProvider = "noStalls")
public void testNoStalls(String uri, boolean sameClient)
public void testNoStalls(String rootUri, boolean sameClient)
throws Exception {
if (!FAILURES.isEmpty()) return;
HttpClient client = null;
out.printf("%ntestNoStalls(%s, %b)%n", uri, sameClient);
out.printf("%ntestNoStalls(%s, %b)%n", rootUri, sameClient);
for (int i=0; i< ITERATION_COUNT; i++) {
if (!sameClient || client == null)
client = newHttpClient(sameClient);
String uri = rootUri + "/" + requestCount.incrementAndGet();
out.printf("\tsending request %s%n", uri);
HttpRequest req = HttpRequest.newBuilder(URI.create(uri))
.build();
BodyHandler<Stream<String>> handler =
@ -331,6 +336,10 @@ public class DependentPromiseActionsTest implements HttpServerAdapters {
SubscriberType subscriberType)
throws Exception
{
if (!FAILURES.isEmpty()) {
out.printf("%s: skipping test - previous failure detected%n", name);
return;
}
out.printf("%n%s%s%n", now(), name);
try {
testDependent(uri, sameClient, handlers, finisher,
@ -341,7 +350,7 @@ public class DependentPromiseActionsTest implements HttpServerAdapters {
}
}
private <T,U> void testDependent(String uri, boolean sameClient,
private <T,U> void testDependent(String rootUri, boolean sameClient,
Supplier<BodyHandler<T>> handlers,
Finisher finisher,
Extractor<T> extractor,
@ -354,6 +363,8 @@ public class DependentPromiseActionsTest implements HttpServerAdapters {
if (!sameClient || client == null)
client = newHttpClient(sameClient);
String uri = rootUri + "/" + requestCount.incrementAndGet();
out.printf("\tsending request %s%n", uri);
HttpRequest req = HttpRequest.
newBuilder(URI.create(uri))
.build();
@ -363,7 +374,13 @@ public class DependentPromiseActionsTest implements HttpServerAdapters {
System.out.println("try stalling in " + where);
CompletableFuture<HttpResponse<T>> responseCF =
client.sendAsync(req, handler, promiseHandler);
assert subscriberType == SubscriberType.LAZZY || !responseCF.isDone();
// The body of the main response can be received before the body
// of the push promise handlers are received.
// The body of the main response doesn't stall, so the cf of
// the main response may be done here even for EAGER subscribers.
// We cannot make any assumption on the state of the main response
// cf here, so the only thing we can do is to call the finisher
// which will wait for them all.
finisher.finish(where, responseCF, promiseHandler, extractor);
}
}