7017486: Need synchronized access when flushing the LDAP request queue

Reviewed-by: alanb
2011-02-07 09:11:26 +00:00 · 2011-02-07 09:11:26 +00:00 · b11e82495a
commit b11e82495a
parent 10439e2650
1 changed files with 10 additions and 7 deletions
--- a/jdk/src/share/classes/com/sun/jndi/ldap/Connection.java
+++ b/jdk/src/share/classes/com/sun/jndi/ldap/Connection.java
@ -656,14 +656,17 @@ public final class Connection implements Runnable {
                }
                nparent = notifyParent;
            }
-        }
-        if (nparent) {
-            LdapRequest ldr = pendingRequests;
-            while (ldr != null) {
-                ldr.notify();
-                ldr = ldr.next;
+            if (nparent) {
+                LdapRequest ldr = pendingRequests;
+                while (ldr != null) {
+
+                    synchronized (ldr) {
+                        ldr.notify();
+                        ldr = ldr.next;
+                    }
+                }
+                parent.processConnectionClosure();
            }
-            parent.processConnectionClosure();
        }
    }