diff --git a/jdk/src/share/classes/java/util/stream/AbstractShortCircuitTask.java b/jdk/src/share/classes/java/util/stream/AbstractShortCircuitTask.java index 7a102e80d8e..484e3efb5ec 100644 --- a/jdk/src/share/classes/java/util/stream/AbstractShortCircuitTask.java +++ b/jdk/src/share/classes/java/util/stream/AbstractShortCircuitTask.java @@ -39,6 +39,7 @@ import java.util.concurrent.atomic.AtomicReference; * @param type of child and sibling tasks * @since 1.8 */ +@SuppressWarnings("serial") abstract class AbstractShortCircuitTask> extends AbstractTask { diff --git a/jdk/src/share/classes/java/util/stream/AbstractTask.java b/jdk/src/share/classes/java/util/stream/AbstractTask.java index b8344e84c59..33de7d5c52a 100644 --- a/jdk/src/share/classes/java/util/stream/AbstractTask.java +++ b/jdk/src/share/classes/java/util/stream/AbstractTask.java @@ -73,6 +73,9 @@ import java.util.concurrent.ForkJoinPool; * } * } * + *

Serialization is not supported as there is no intention to serialize + * tasks managed by stream ops. + * * @param Type of elements input to the pipeline * @param Type of elements output from the pipeline * @param Type of intermediate result, which may be different from operation @@ -80,6 +83,7 @@ import java.util.concurrent.ForkJoinPool; * @param Type of parent, child and sibling tasks * @since 1.8 */ +@SuppressWarnings("serial") abstract class AbstractTask> extends CountedCompleter { diff --git a/jdk/src/share/classes/java/util/stream/FindOps.java b/jdk/src/share/classes/java/util/stream/FindOps.java index 6b34b24244d..197d99c0890 100644 --- a/jdk/src/share/classes/java/util/stream/FindOps.java +++ b/jdk/src/share/classes/java/util/stream/FindOps.java @@ -246,6 +246,7 @@ final class FindOps { * @param Output element type from the stream pipeline * @param Result type from the find operation */ + @SuppressWarnings("serial") private static final class FindTask extends AbstractShortCircuitTask> { private final FindOp op; diff --git a/jdk/src/share/classes/java/util/stream/ForEachOps.java b/jdk/src/share/classes/java/util/stream/ForEachOps.java index 0d9ea6a69c3..2c343fbc3c1 100644 --- a/jdk/src/share/classes/java/util/stream/ForEachOps.java +++ b/jdk/src/share/classes/java/util/stream/ForEachOps.java @@ -249,6 +249,7 @@ final class ForEachOps { } /** A {@code ForkJoinTask} for performing a parallel for-each operation */ + @SuppressWarnings("serial") static final class ForEachTask extends CountedCompleter { private Spliterator spliterator; private final Sink sink; @@ -314,6 +315,7 @@ final class ForEachOps { * A {@code ForkJoinTask} for performing a parallel for-each operation * which visits the elements in encounter order */ + @SuppressWarnings("serial") static final class ForEachOrderedTask extends CountedCompleter { private final PipelineHelper helper; private Spliterator spliterator; diff --git a/jdk/src/share/classes/java/util/stream/MatchOps.java b/jdk/src/share/classes/java/util/stream/MatchOps.java index 0f9362adfc9..cc809e4acea 100644 --- a/jdk/src/share/classes/java/util/stream/MatchOps.java +++ b/jdk/src/share/classes/java/util/stream/MatchOps.java @@ -274,6 +274,7 @@ final class MatchOps { * @param the type of source elements for the pipeline * @param the type of output elements for the pipeline */ + @SuppressWarnings("serial") private static final class MatchTask extends AbstractShortCircuitTask> { private final MatchOp op; diff --git a/jdk/src/share/classes/java/util/stream/Nodes.java b/jdk/src/share/classes/java/util/stream/Nodes.java index 4edf324a84c..e39a5733717 100644 --- a/jdk/src/share/classes/java/util/stream/Nodes.java +++ b/jdk/src/share/classes/java/util/stream/Nodes.java @@ -1786,6 +1786,10 @@ final class Nodes { } } + /* + * This and subclasses are not intended to be serializable + */ + @SuppressWarnings("serial") private static abstract class SizedCollectorTask, K extends SizedCollectorTask> extends CountedCompleter @@ -1855,6 +1859,7 @@ final class Nodes { fence = (int) offset + (int) length; } + @SuppressWarnings("serial") static final class OfRef extends SizedCollectorTask, OfRef> implements Sink { @@ -1886,6 +1891,7 @@ final class Nodes { } } + @SuppressWarnings("serial") static final class OfInt extends SizedCollectorTask> implements Sink.OfInt { @@ -1917,6 +1923,7 @@ final class Nodes { } } + @SuppressWarnings("serial") static final class OfLong extends SizedCollectorTask> implements Sink.OfLong { @@ -1948,6 +1955,7 @@ final class Nodes { } } + @SuppressWarnings("serial") static final class OfDouble extends SizedCollectorTask> implements Sink.OfDouble { @@ -1980,6 +1988,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static abstract class ToArrayTask, K extends ToArrayTask> extends CountedCompleter { @@ -2025,6 +2034,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static final class OfRef extends ToArrayTask, OfRef> { private final T[] array; @@ -2050,6 +2060,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static class OfPrimitive, T_NODE extends Node.OfPrimitive> @@ -2077,6 +2088,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static final class OfInt extends OfPrimitive { private OfInt(Node.OfInt node, int[] array, int offset) { @@ -2084,6 +2096,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static final class OfLong extends OfPrimitive { private OfLong(Node.OfLong node, long[] array, int offset) { @@ -2091,6 +2104,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static final class OfDouble extends OfPrimitive { private OfDouble(Node.OfDouble node, double[] array, int offset) { @@ -2099,6 +2113,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static class CollectorTask, T_BUILDER extends Node.Builder> extends AbstractTask> { protected final PipelineHelper helper; @@ -2141,6 +2156,7 @@ final class Nodes { super.onCompletion(caller); } + @SuppressWarnings("serial") private static final class OfRef extends CollectorTask, Node.Builder> { OfRef(PipelineHelper helper, @@ -2150,6 +2166,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static final class OfInt extends CollectorTask { OfInt(PipelineHelper helper, Spliterator spliterator) { @@ -2157,6 +2174,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static final class OfLong extends CollectorTask { OfLong(PipelineHelper helper, Spliterator spliterator) { @@ -2164,6 +2182,7 @@ final class Nodes { } } + @SuppressWarnings("serial") private static final class OfDouble extends CollectorTask { OfDouble(PipelineHelper helper, Spliterator spliterator) { diff --git a/jdk/src/share/classes/java/util/stream/ReduceOps.java b/jdk/src/share/classes/java/util/stream/ReduceOps.java index 20d3336863b..754a4774a3d 100644 --- a/jdk/src/share/classes/java/util/stream/ReduceOps.java +++ b/jdk/src/share/classes/java/util/stream/ReduceOps.java @@ -43,7 +43,7 @@ import java.util.function.ObjLongConsumer; import java.util.function.Supplier; /** - * Factory for the creating instances of {@code TerminalOp) that implement + * Factory for creating instances of {@code TerminalOp} that implement * reductions. * * @since 1.8 @@ -718,6 +718,7 @@ final class ReduceOps { /** * A {@code ForkJoinTask} for performing a parallel reduce operation. */ + @SuppressWarnings("serial") private static final class ReduceTask> extends AbstractTask> { diff --git a/jdk/src/share/classes/java/util/stream/SliceOps.java b/jdk/src/share/classes/java/util/stream/SliceOps.java index ac538f2d86c..09e14f637f4 100644 --- a/jdk/src/share/classes/java/util/stream/SliceOps.java +++ b/jdk/src/share/classes/java/util/stream/SliceOps.java @@ -550,6 +550,7 @@ final class SliceOps { * @param Input element type to the stream pipeline * @param Output element type from the stream pipeline */ + @SuppressWarnings("serial") private static final class SliceTask extends AbstractShortCircuitTask, SliceTask> { private final AbstractPipeline op;