stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8000332: SA ClassDump throws exception after permgen removal

Browse Source 
In ClassWrite.writeFields(), fields count was mistakenly set to fields length which overflow the array index. Also removed a file which is leftover from 6879063 changeset.

Reviewed-by: coleenp, sspitsyn
This commit is contained in:
Yumin Qi 2012-10-08 16:48:52 -07:00 committed by Yumin Qi
parent 80d5f4b66d
commit b2cf8c4cb0
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hotspot/agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java
View File

@ -354,15 +354,14 @@ public class ClassWriter implements /* imports */ ClassConstants
}
protected void writeFields() throws IOException {
U2Array fields = klass.getFields();
final int length = (int) fields.length();
final int javaFieldsCount = klass.getJavaFieldsCount();
// write number of fields
dos.writeShort((short) length);
dos.writeShort((short) javaFieldsCount);
if (DEBUG) debugMessage("number of fields = " + length);
if (DEBUG) debugMessage("number of fields = " + javaFieldsCount);
for (int index = 0; index < length; index++) {
for (int index = 0; index < javaFieldsCount; index++) {
short accessFlags = klass.getFieldAccessFlags(index);
dos.writeShort(accessFlags & (short) JVM_RECOGNIZED_FIELD_MODIFIERS);

2
hotspot/agent/src/share/native/sadis.c
View File

@ -46,7 +46,7 @@
#else
#include <strings.h>
#include <string.h>
#include <dlfcn.h>
#include <link.h>