stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8216426: Usage of array placement new may lead to memory corruption

Browse Source 
Reviewed-by: rehn, kbarrett, rkennke, eosterlund
This commit is contained in:
Martin Doerr 2019-01-15 10:23:23 +01:00
parent 744d6085b4
commit b2f82b3bd3
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hotspot/share/utilities/concurrentHashTable.hpp
View File

@ -73,7 +73,7 @@ class ConcurrentHashTable : public CHeapObj<F> {
void print_value_on(outputStream* st) const {}; void print_value_on(outputStream* st) const {};
}; };
// Only constructed with placement new[] from an array allocated with MEMFLAGS // Only constructed with placement new from an array allocated with MEMFLAGS
// of InternalTable. // of InternalTable.
class Bucket { class Bucket {
private: private:

8
src/hotspot/share/utilities/concurrentHashTable.inline.hpp
View File

@ -193,8 +193,12 @@ inline ConcurrentHashTable<VALUE, CONFIG, F>::
{ {
assert(_log2_size >= SIZE_SMALL_LOG2 && _log2_size <= SIZE_BIG_LOG2, assert(_log2_size >= SIZE_SMALL_LOG2 && _log2_size <= SIZE_BIG_LOG2,
"Bad size"); "Bad size");
void* memory = NEW_C_HEAP_ARRAY(Bucket, _size, F); _buckets = NEW_C_HEAP_ARRAY(Bucket, _size, F);
_buckets = new (memory) Bucket[_size]; // Use placement new for each element instead of new[] which could use more
// memory than allocated.
for (size_t i = 0; i < _size; ++i) {
new (_buckets + i) Bucket();
}
} }
template <typename VALUE, typename CONFIG, MEMFLAGS F> template <typename VALUE, typename CONFIG, MEMFLAGS F>