stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8240511: Shenandoah: parallel safepoint workers count should be ParallelGCThreads

Browse Source 
Reviewed-by: rkennke
This commit is contained in:
Aleksey Shipilev 2020-03-04 11:50:28 +01:00
parent 8e74ed46df
commit b3666b94a3
3 changed files with 2 additions and 52 deletions
src/hotspot/share/gc/shenandoah
shenandoahHeap.cppshenandoah_globals.hpp
test/hotspot/jtreg/gc/shenandoah/options
TestSafepointWorkers.java

4
src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

@ -478,9 +478,9 @@ ShenandoahHeap::ShenandoahHeap(ShenandoahCollectorPolicy* policy) :
_workers->initialize_workers();
}
if (ShenandoahParallelSafepointThreads > 1) {
if (ParallelGCThreads > 1) {
_safepoint_workers = new ShenandoahWorkGang("Safepoint Cleanup Thread",
ShenandoahParallelSafepointThreads,
ParallelGCThreads,
/* are_GC_task_threads */ false,
/* are_ConcurrentGC_threads */ false);
_safepoint_workers->initialize_workers();

3
src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

@ -317,9 +317,6 @@
"Forcefully flush non-empty SATB buffers at this interval. " \
"Time is in milliseconds.") \
\
experimental(uint, ShenandoahParallelSafepointThreads, 4, \
"Number of parallel threads used for safepoint prolog/epilog") \
\
diagnostic(bool, ShenandoahPreclean, true, \
"Do concurrent preclean phase before final mark: process " \
"definitely alive references to avoid dealing with them during " \

47
test/hotspot/jtreg/gc/shenandoah/options/TestSafepointWorkers.java

@ -1,47 +0,0 @@
/*
* Copyright (c) 2019, Red Hat, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*
*/
/*
* @test TestSingleSafepointWorker
* @key gc
* @requires vm.gc.Shenandoah & !vm.graal.enabled
*
* @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:ShenandoahParallelSafepointThreads=1 -Xmx128m TestSafepointWorkers
* @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:ShenandoahParallelSafepointThreads=2 -Xmx128m TestSafepointWorkers
* @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:ShenandoahParallelSafepointThreads=4 -Xmx128m TestSafepointWorkers
* @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:ShenandoahParallelSafepointThreads=8 -Xmx128m TestSafepointWorkers
*/
public class TestSafepointWorkers {
static final long TARGET_MB = Long.getLong("target", 1000); // 1 Gb allocation
static volatile Object sink;
public static void main(String[] args) throws Exception {
long count = TARGET_MB * 1024 * 1024 / 16;
for (long c = 0; c < count; c++) {
sink = new Object();
}
}
}