stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

7033100: CreateMinidumpOnCrash does not work for failed asserts

Browse Source 
Passing NULL as MINIDUMP_EXCEPTION_INFORMATION when calling MiniDumpWriteDump when crash is due to assertion instead of real exception to avoid creating zero-length mini dump file.

Reviewed-by: acorn, dcubed, poonam, coleenp
This commit is contained in:
Zhengyu Gu 2011-04-14 11:50:36 -04:00
parent 3c4d3002f2
commit b3eb7daed6
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hotspot/src/os/windows/vm/os_windows.cpp
View File

@ -921,6 +921,8 @@ void os::check_or_create_dump(void* exceptionRecord, void* contextRecord, char*
HINSTANCE dbghelp; HINSTANCE dbghelp;
EXCEPTION_POINTERS ep; EXCEPTION_POINTERS ep;
MINIDUMP_EXCEPTION_INFORMATION mei; MINIDUMP_EXCEPTION_INFORMATION mei;
MINIDUMP_EXCEPTION_INFORMATION* pmei;
HANDLE hProcess = GetCurrentProcess(); HANDLE hProcess = GetCurrentProcess();
DWORD processId = GetCurrentProcessId(); DWORD processId = GetCurrentProcessId();
HANDLE dumpFile; HANDLE dumpFile;
@ -971,17 +973,22 @@ void os::check_or_create_dump(void* exceptionRecord, void* contextRecord, char*
VMError::report_coredump_status("Failed to create file for dumping", false); VMError::report_coredump_status("Failed to create file for dumping", false);
return; return;
} }
if (exceptionRecord != NULL && contextRecord != NULL) {
ep.ContextRecord = (PCONTEXT) contextRecord; ep.ContextRecord = (PCONTEXT) contextRecord;
ep.ExceptionRecord = (PEXCEPTION_RECORD) exceptionRecord; ep.ExceptionRecord = (PEXCEPTION_RECORD) exceptionRecord;
mei.ThreadId = GetCurrentThreadId(); mei.ThreadId = GetCurrentThreadId();
mei.ExceptionPointers = &ep; mei.ExceptionPointers = &ep;
pmei = &mei;
} else {
pmei = NULL;
}
// Older versions of dbghelp.dll (the one shipped with Win2003 for example) may not support all // Older versions of dbghelp.dll (the one shipped with Win2003 for example) may not support all
// the dump types we really want. If first call fails, lets fall back to just use MiniDumpWithFullMemory then. // the dump types we really want. If first call fails, lets fall back to just use MiniDumpWithFullMemory then.
if (_MiniDumpWriteDump(hProcess, processId, dumpFile, dumpType, &mei, NULL, NULL) == false && if (_MiniDumpWriteDump(hProcess, processId, dumpFile, dumpType, pmei, NULL, NULL) == false &&
_MiniDumpWriteDump(hProcess, processId, dumpFile, (MINIDUMP_TYPE)MiniDumpWithFullMemory, &mei, NULL, NULL) == false) { _MiniDumpWriteDump(hProcess, processId, dumpFile, (MINIDUMP_TYPE)MiniDumpWithFullMemory, pmei, NULL, NULL) == false) {
VMError::report_coredump_status("Call to MiniDumpWriteDump() failed", false); VMError::report_coredump_status("Call to MiniDumpWriteDump() failed", false);
} else { } else {
VMError::report_coredump_status(buffer, true); VMError::report_coredump_status(buffer, true);