8233387: Shenandoah: passive mode should disable pacing ergonomically

Reviewed-by: zgu
This commit is contained in:
Aleksey Shipilev 2019-11-01 16:16:05 +01:00
parent 026e83632d
commit b56749537d
3 changed files with 2 additions and 9 deletions

View File

@ -29,11 +29,6 @@
#include "logging/log.hpp"
#include "logging/logTag.hpp"
ShenandoahPassiveHeuristics::ShenandoahPassiveHeuristics() : ShenandoahHeuristics() {
// Passive runs with max speed for allocation, because GC is always STW
SHENANDOAH_ERGO_DISABLE_FLAG(ShenandoahPacing);
}
bool ShenandoahPassiveHeuristics::should_start_gc() const {
// Never do concurrent GCs.
return false;

View File

@ -28,8 +28,6 @@
class ShenandoahPassiveHeuristics : public ShenandoahHeuristics {
public:
ShenandoahPassiveHeuristics();
virtual bool should_start_gc() const;
virtual bool should_process_references();

View File

@ -32,8 +32,8 @@ void ShenandoahPassiveMode::initialize_flags() const {
FLAG_SET_DEFAULT(ExplicitGCInvokesConcurrent, false);
FLAG_SET_DEFAULT(ShenandoahImplicitGCInvokesConcurrent, false);
// Passive runs with max speed, reacts on allocation failure.
FLAG_SET_DEFAULT(ShenandoahPacing, false);
// Passive runs with max speed for allocation, because GC is always STW
SHENANDOAH_ERGO_DISABLE_FLAG(ShenandoahPacing);
// No need for evacuation reserve with Full GC, only for Degenerated GC.
if (!ShenandoahDegeneratedGC) {