stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8190324: ThreadPoolExecutor should not specify a dependency on finalization

Browse Source 
Reviewed-by: martin, psandoz, alanb, rriggs, dholmes
This commit is contained in:
Doug Lea 2018-02-10 09:17:53 -08:00
parent 987c3a2d87
commit b6c2b234ef
2 changed files with 29 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/java.base/share/classes/java/util/concurrent/ThreadPoolExecutor.java
View File

@ -35,9 +35,6 @@
package java.util.concurrent;
import java.security.AccessControlContext;
import java.security.AccessController;
import java.security.PrivilegedAction;
import java.util.ArrayList;
import java.util.ConcurrentModificationException;
import java.util.HashSet;
@ -268,8 +265,8 @@ import java.util.concurrent.locks.ReentrantLock;
*
* <dd>A pool that is no longer referenced in a program <em>AND</em>
* has no remaining threads may be reclaimed (garbage collected)
* without being explicity shutdown. You can configure a pool to allow
* all unused threads to eventually die by setting appropriate
* without being explicitly shutdown. You can configure a pool to
* allow all unused threads to eventually die by setting appropriate
* keep-alive times, using a lower bound of zero core threads and/or
* setting {@link #allowCoreThreadTimeOut(boolean)}. </dd>
*
@ -1462,6 +1459,18 @@ public class ThreadPoolExecutor extends AbstractExecutorService {
}
}
// Override without "throws Throwable" for compatibility with subclasses
// whose finalize method invokes super.finalize() (as is recommended).
// Before JDK 11, finalize() had a non-empty method body.
/**
* @implNote Previous versions of this class had a finalize method
* that shut down this executor, but in this version, finalize
* does nothing.
*/
@Deprecated(since="9")
protected void finalize() {}
/**
* Sets the thread factory used to create new threads.
*

15
test/jdk/java/util/concurrent/tck/ThreadPoolExecutorSubclassTest.java
View File

@ -1994,4 +1994,19 @@ public class ThreadPoolExecutorSubclassTest extends JSR166TestCase {
}
}
public void testFinalizeMethodCallsSuperFinalize() {
new CustomTPE(1, 1,
LONG_DELAY_MS, MILLISECONDS,
new LinkedBlockingQueue<Runnable>()) {
/**
* A finalize method without "throws Throwable", that
* calls super.finalize().
*/
protected void finalize() {
super.finalize();
}
}.shutdown();
}
}