stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

7037756: Deadlock in compiler thread similiar to 6789220

Browse Source 
Avoid blocking in CompileBroker::compile_method_base() if the current thread holds the pending list lock.

Reviewed-by: never, brutisso, ysr
This commit is contained in:
John Cuthbertson 2011-04-27 14:40:41 -07:00
parent d86311b13c
commit b777d36af8
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
hotspot/src/share/vm/compiler/compileBroker.cpp
View File

@ -976,6 +976,15 @@ void CompileBroker::compile_method_base(methodHandle method,
return; return;
} }
// If the requesting thread is holding the pending list lock
// then we just return. We can't risk blocking while holding
// the pending list lock or a 3-way deadlock may occur
// between the reference handler thread, a GC (instigated
// by a compiler thread), and compiled method registration.
if (instanceRefKlass::owns_pending_list_lock(JavaThread::current())) {
return;
}
// Outputs from the following MutexLocker block: // Outputs from the following MutexLocker block:
CompileTask* task = NULL; CompileTask* task = NULL;
bool blocking = false; bool blocking = false;
@ -1304,17 +1313,8 @@ uint CompileBroker::assign_compile_id(methodHandle method, int osr_bci) {
// Should the current thread be blocked until this compilation request // Should the current thread be blocked until this compilation request
// has been fulfilled? // has been fulfilled?
bool CompileBroker::is_compile_blocking(methodHandle method, int osr_bci) { bool CompileBroker::is_compile_blocking(methodHandle method, int osr_bci) {
if (!BackgroundCompilation) { assert(!instanceRefKlass::owns_pending_list_lock(JavaThread::current()), "possible deadlock");
Symbol* class_name = method->method_holder()->klass_part()->name(); return !BackgroundCompilation;
if (class_name->starts_with("java/lang/ref/Reference", 23)) {
// The reference handler thread can dead lock with the GC if compilation is blocking,
// so we avoid blocking compiles for anything in the java.lang.ref.Reference class,
// including inner classes such as ReferenceHandler.
return false;
}
return true;
}
return false;
} }