stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8135075: Reorder short-circuit tests in ApplySpecialization to run cheapest first

Browse Source 
Reviewed-by: hannesw, mhaupt, sundar
This commit is contained in:
Attila Szegedi 2015-09-07 11:11:41 +02:00
parent cb025d0a9a
commit bb5c8037e7
1 changed files with 22 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/ApplySpecialization.java
View File

@ -298,7 +298,28 @@ public final class ApplySpecialization extends NodeVisitor<LexicalContext> imple
@Override
public boolean enterFunctionNode(final FunctionNode functionNode) {
if (!USE_APPLY2CALL) {
// Cheap tests first
if (!(
// is the transform globally enabled?
USE_APPLY2CALL
// Are we compiling lazily? We can't known the number and types of the actual parameters at
// the caller when compiling eagerly, so this only works with on-demand compilation.
&& compiler.isOnDemandCompilation()
// Does the function even reference the "arguments" identifier (without redefining it)? If not,
// it trivially can't have an expression of form "f.apply(self, arguments)" that this transform
// is targeting.
&& functionNode.needsArguments()
// Does the function have eval? If so, it can arbitrarily modify arguments so we can't touch it.
&& !functionNode.hasEval()
// Finally, does the function declare any parameters explicitly? We don't support that. It could
// be done, but has some complications. Therefore only a function with no explicit parameters
// is considered.
&& functionNode.getNumOfParams() == 0))
{
return false;
}
@ -308,18 +329,6 @@ public final class ApplySpecialization extends NodeVisitor<LexicalContext> imple
return false;
}
if (!compiler.isOnDemandCompilation()) {
return false;
}
if (functionNode.getNumOfParams() != 0) {
return false;
}
if (functionNode.hasEval()) {
return false;
}
if (!hasApplies(functionNode)) {
return false;
}