stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8032004: instance property "message" of Error objects should be non-enumerable

Browse Source 
Reviewed-by: hannesw, jlaskey
This commit is contained in:
Athijegannathan Sundararajan 2014-01-16 22:50:53 +05:30
parent 9ce7db11e3
commit bb600b7978
9 changed files with 51 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nashorn/src/jdk/nashorn/internal/objects/NativeError.java
View File

@ -74,7 +74,7 @@ public final class NativeError extends ScriptObject {
static final String FILENAME = "__fileName__";
/** Message property name */
@Property(name = NativeError.MESSAGE)
@Property(name = NativeError.MESSAGE, attributes = Attribute.NOT_ENUMERABLE)
public Object instMessage;
/** ECMA 15.11.4.2 Error.prototype.name */

2
nashorn/src/jdk/nashorn/internal/objects/NativeEvalError.java
View File

@ -44,7 +44,7 @@ import jdk.nashorn.internal.runtime.ScriptObject;
public final class NativeEvalError extends ScriptObject {
/** message property in instance */
@Property(name = NativeError.MESSAGE)
@Property(name = NativeError.MESSAGE, attributes = Attribute.NOT_ENUMERABLE)
public Object instMessage;
/** error name property */

2
nashorn/src/jdk/nashorn/internal/objects/NativeRangeError.java
View File

@ -44,7 +44,7 @@ import jdk.nashorn.internal.runtime.ScriptObject;
public final class NativeRangeError extends ScriptObject {
/** message property in instance */
@Property(name = NativeError.MESSAGE)
@Property(name = NativeError.MESSAGE, attributes = Attribute.NOT_ENUMERABLE)
public Object instMessage;
/** error name property */

2
nashorn/src/jdk/nashorn/internal/objects/NativeReferenceError.java
View File

@ -44,7 +44,7 @@ import jdk.nashorn.internal.runtime.ScriptObject;
public final class NativeReferenceError extends ScriptObject {
/** message property in instance */
@Property(name = NativeError.MESSAGE)
@Property(name = NativeError.MESSAGE, attributes = Attribute.NOT_ENUMERABLE)
public Object instMessage;
/** error name property */

2
nashorn/src/jdk/nashorn/internal/objects/NativeSyntaxError.java
View File

@ -44,7 +44,7 @@ import jdk.nashorn.internal.runtime.ScriptObject;
public final class NativeSyntaxError extends ScriptObject {
/** message property in instance */
@Property(name = NativeError.MESSAGE)
@Property(name = NativeError.MESSAGE, attributes = Attribute.NOT_ENUMERABLE)
public Object instMessage;
/** error name property */

2
nashorn/src/jdk/nashorn/internal/objects/NativeTypeError.java
View File

@ -44,7 +44,7 @@ import jdk.nashorn.internal.runtime.ScriptObject;
public final class NativeTypeError extends ScriptObject {
/** message property in instance */
@Property(name = NativeError.MESSAGE)
@Property(name = NativeError.MESSAGE, attributes = Attribute.NOT_ENUMERABLE)
public Object instMessage;
/** error name property */

2
nashorn/src/jdk/nashorn/internal/objects/NativeURIError.java
View File

@ -43,7 +43,7 @@ import jdk.nashorn.internal.runtime.ScriptObject;
public final class NativeURIError extends ScriptObject {
/** message property in instance */
@Property(name = NativeError.MESSAGE)
@Property(name = NativeError.MESSAGE, attributes = Attribute.NOT_ENUMERABLE)
public Object instMessage;
/** error name property */

43
nashorn/test/script/basic/JDK-8032004.js Normal file
View File

@ -0,0 +1,43 @@
/*
* Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* JDK-8032004: instance property "message" of Error objects should be non-enumerable
*
* @test
* @run
*/
function check(obj) {
if (obj.propertyIsEnumerable("message")) {
fail(obj.name + " object's message property is enumerable!");
}
}
check(new Error("test"));
check(new EvalError("test"));
check(new RangeError("test"));
check(new ReferenceError("test"));
check(new SyntaxError("test"));
check(new TypeError("test"));
check(new URIError("test"));

2
nashorn/test/script/basic/NASHORN-111.js.EXPECTED
View File

@ -1 +1 @@
{"message":"type error"}
{}