8135000: Number.prototype.toFixed returns wrong string for 0.5 and -0.5

Reviewed-by: attila, sundar
This commit is contained in:
Hannes Wallnöfer 2015-09-10 13:46:45 +02:00
parent 01de8c1714
commit bc7be8c881
3 changed files with 68 additions and 0 deletions

View File

@ -33,6 +33,7 @@ import static jdk.nashorn.internal.runtime.ScriptRuntime.UNDEFINED;
import java.lang.invoke.MethodHandle;
import java.lang.invoke.MethodHandles;
import java.lang.invoke.MethodType;
import java.math.RoundingMode;
import java.text.NumberFormat;
import java.util.Locale;
import jdk.internal.dynalink.linker.GuardedInvocation;
@ -187,6 +188,7 @@ public final class NativeNumber extends ScriptObject {
format.setMinimumFractionDigits(fractionDigits);
format.setMaximumFractionDigits(fractionDigits);
format.setGroupingUsed(false);
format.setRoundingMode(RoundingMode.HALF_UP);
return format.format(x);
}

View File

@ -0,0 +1,48 @@
/*
* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* JDK-8135000: Number.prototype.toFixed returns wrong string for 0.5 and -0.5
*
* @test
* @run
*/
print(-2.6.toFixed());
print(-2.5.toFixed());
print(-2.4.toFixed());
print(-1.6.toFixed());
print(-1.5.toFixed());
print(-1.4.toFixed());
print(-0.6.toFixed());
print(-0.5.toFixed());
print(-0.4.toFixed());
print(0.4.toFixed());
print(0.5.toFixed());
print(0.6.toFixed());
print(1.4.toFixed());
print(1.5.toFixed());
print(1.6.toFixed());
print(2.4.toFixed());
print(2.5.toFixed());
print(2.6.toFixed());

View File

@ -0,0 +1,18 @@
-3
-3
-2
-2
-2
-1
-1
-1
0
0
1
1
1
2
2
2
3
3