7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource
Missing name check before calling MethodSymbol.overrides causes wrong warnings to be issued Reviewed-by: jjg
This commit is contained in:
parent
cd57e9960f
commit
be712a0152
langtools
@ -2289,6 +2289,7 @@ public class Attr extends JCTree.Visitor {
|
||||
sitesym.kind == VAR &&
|
||||
((VarSymbol)sitesym).isResourceVariable() &&
|
||||
sym.kind == MTH &&
|
||||
sym.name.equals(names.close) &&
|
||||
sym.overrides(syms.autoCloseableClose, sitesym.type.tsym, types, true) &&
|
||||
env.info.lint.isEnabled(LintCategory.TRY)) {
|
||||
log.warning(LintCategory.TRY, tree, "try.explicit.close.call");
|
||||
|
40
langtools/test/tools/javac/TryWithResources/T7032633.java
Normal file
40
langtools/test/tools/javac/TryWithResources/T7032633.java
Normal file
@ -0,0 +1,40 @@
|
||||
/*
|
||||
* Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
|
||||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
||||
*
|
||||
* This code is free software; you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License version 2 only, as
|
||||
* published by the Free Software Foundation.
|
||||
*
|
||||
* This code is distributed in the hope that it will be useful, but WITHOUT
|
||||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
||||
* version 2 for more details (a copy is included in the LICENSE file that
|
||||
* accompanied this code).
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License version
|
||||
* 2 along with this work; if not, write to the Free Software Foundation,
|
||||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
||||
*
|
||||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
||||
* or visit www.oracle.com if you need additional information or have any
|
||||
* questions.
|
||||
*/
|
||||
|
||||
/*
|
||||
* @test
|
||||
* @bug 7032633
|
||||
* @summary javac -Xlint:all warns about flush() within try on an auto-closeable resource
|
||||
* @compile -Xlint:try -Werror T7032633.java
|
||||
*/
|
||||
|
||||
import java.io.IOException;
|
||||
import java.io.OutputStream;
|
||||
|
||||
public class T7032633 {
|
||||
void test() throws IOException {
|
||||
try (OutputStream out = System.out) {
|
||||
out.flush();
|
||||
}
|
||||
}
|
||||
}
|
Loading…
x
Reference in New Issue
Block a user