stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8145051: Wrong parameter name in synthetic lambda method leads to verifier error

Browse Source 
Synthetic names manufactured by the compiler should not contain '.'

Reviewed-by: mcimadamore
This commit is contained in:
Srikanth Adayapalam 2015-12-10 17:24:59 +05:30
parent 8630db94da
commit bf65927c33
3 changed files with 87 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
View File

@ -2037,7 +2037,7 @@ public class LambdaToMethod extends TreeTranslator {
};
break;
case CAPTURED_OUTER_THIS:
Name name = names.fromString(new String(sym.flatName().toString() + names.dollarThis));
Name name = names.fromString(new String(sym.flatName().toString().replace('.', '$') + names.dollarThis));
ret = new VarSymbol(SYNTHETIC | FINAL | PARAMETER, name, types.erasure(sym.type), translatedSym) {
@Override
public Symbol baseSymbol() {

43
langtools/test/tools/javac/lambda/T8145051.java Normal file
View File

@ -0,0 +1,43 @@
/*
* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8145051
* @summary Wrong parameter name in synthetic lambda method leads to verifier error
* @compile pkg/T8145051.java
* @run main/othervm -Xverify:all T8145051
*/
public class T8145051 {
public static void main(String [] args) {
pkg.T8145051 t8145051 = new pkg.T8145051();
t8145051.new Sub();
if (!t8145051.s.equals("Executed lambda"))
throw new AssertionError("Unexpected data");
else
System.out.println("OK");
}
}

43
langtools/test/tools/javac/lambda/pkg/T8145051.java Normal file
View File

@ -0,0 +1,43 @@
/*
* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
package pkg;
public class T8145051 {
public String s;
public static class Sup {
Sup(Runnable r) {
r.run();
}
}
public class Sub extends Sup {
public Sub() {
super(() -> {
s = "Executed lambda";
});
}
}
}