stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17

Browse Source 
Reviewed-by: kvn, thartmann, chagedorn
This commit is contained in:
Roland Westrelin 2023-07-19 11:31:49 +00:00
parent d33e8e6f93
commit c6ab9c2905
2 changed files with 70 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hotspot/share/opto/loopopts.cpp
View File

@ -1696,7 +1696,13 @@ void PhaseIdealLoop::try_sink_out_of_loop(Node* n) {
cast = ConstraintCastNode::make_cast_for_type(x_ctrl, in, in_t, ConstraintCastNode::UnconditionalDependency);
}
if (cast != nullptr) {
register_new_node(cast, x_ctrl);
Node* prev = _igvn.hash_find_insert(cast);
if (prev != nullptr) {
cast->destruct(&_igvn);
cast = prev;
} else {
register_new_node(cast, x_ctrl);
}
x->replace_edge(in, cast);
// Chain of AddP:
// 2- A CastPP of the base is only added now that both AddP nodes are sunk

63
test/hotspot/jtreg/compiler/loopopts/TestSinkingNodesCausesLongCompilation.java Normal file
View File

@ -0,0 +1,63 @@
/*
* Copyright (c) 2023, Red Hat, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8308103
* @summary Massive (up to ~30x) increase in C2 compilation time since JDK 17
* @run main/othervm -Xcomp -XX:CompileOnly=TestSinkingNodesCausesLongCompilation::mainTest -XX:+UnlockDiagnosticVMOptions
* -XX:RepeatCompilation=30 TestSinkingNodesCausesLongCompilation
*/
public class TestSinkingNodesCausesLongCompilation {
public static final int N = 400;
public static int iFld=41489;
public void mainTest(String[] strArr1) {
int i9=-13, i10=-248, i11=-4, i13=33, i15=-171, i18=-58, iArr2[]=new int[N];
for (i9 = 7; i9 < 256; i9++) {
i11 = 1;
do {
} while (++i11 < 101);
}
for (int i14 : iArr2) {
for (i15 = 63; 0 < i15; i15 -= 2) {
i10 *= i13;
i10 >>= i14;
}
for (i18 = 2; 63 > i18; i18++) {
i10 = iFld;
iArr2[i18] |= i11;
}
}
System.out.println("i9 = " + i9);
}
public static void main(String[] strArr) {
TestSinkingNodesCausesLongCompilation _instance = new TestSinkingNodesCausesLongCompilation();
for (int i = 0; i < 10; i++) {
_instance.mainTest(strArr);
}
}
}