stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds

Browse Source 
Reviewed-by: wkemper, kdnilsen, rkennke
This commit is contained in:
Aleksey Shipilev 2023-11-29 20:15:44 +00:00
parent d1e73b1299
commit c86431767e
4 changed files with 2 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp
View File

@ -355,7 +355,7 @@
product(bool, ShenandoahStackWatermarkBarrier, true, DIAGNOSTIC, \
"Turn on/off stack watermark barriers in Shenandoah") \
\
develop(bool, ShenandoahVerifyOptoBarriers, false, \
develop(bool, ShenandoahVerifyOptoBarriers, trueInDebug, \
"Verify no missing barriers in C2.") \
\
product(bool, ShenandoahLoopOptsAfterExpansion, true, DIAGNOSTIC, \

1
test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java
View File

@ -97,7 +97,6 @@
* -XX:+UnlockDiagnosticVMOptions
* -XX:-CreateCoredumpOnCrash
* -XX:+ShenandoahVerify
* -XX:+IgnoreUnrecognizedVMOptions -XX:+ShenandoahVerifyOptoBarriers
* -XX:CompileCommand=dontinline,*::mergeImpl*
* compiler.gcbarriers.UnsafeIntrinsicsTest
*/

35
test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java
View File

@ -40,30 +40,10 @@
* TestVerifyJCStress
*/
/*
* @test id=default-debug
* @summary Tests that we pass at least one jcstress-like test with all verification turned on
* @requires vm.gc.Shenandoah
* @requires vm.debug
* @modules java.base/jdk.internal.misc
* java.management
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=adaptive
* -XX:+ShenandoahVerify -XX:+ShenandoahVerifyOptoBarriers
* TestVerifyJCStress
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=compact
* -XX:+ShenandoahVerify -XX:+ShenandoahVerifyOptoBarriers
* TestVerifyJCStress
*/
/*
* @test id=default
* @summary Tests that we pass at least one jcstress-like test with all verification turned on
* @requires vm.gc.Shenandoah
* @requires !vm.debug
* @modules java.base/jdk.internal.misc
* java.management
*
@ -78,25 +58,10 @@
* TestVerifyJCStress
*/
/*
* @test id=iu-debug
* @summary Tests that we pass at least one jcstress-like test with all verification turned on
* @requires vm.gc.Shenandoah
* @requires vm.debug
* @modules java.base/jdk.internal.misc
* java.management
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu
* -XX:+ShenandoahVerify -XX:+ShenandoahVerifyOptoBarriers
* TestVerifyJCStress
*/
/*
* @test id=iu
* @summary Tests that we pass at least one jcstress-like test with all verification turned on
* @requires vm.gc.Shenandoah
* @requires !vm.debug
* @modules java.base/jdk.internal.misc
* java.management
*

3
test/hotspot/jtreg/gc/shenandoah/options/TestSelectiveBarrierFlags.java
View File

@ -35,9 +35,8 @@
* @summary Test selective barrier enabling works, by aggressively compiling HelloWorld with combinations
* of barrier flags
* @requires vm.gc.Shenandoah
* @requires vm.debug
* @library /test/lib
* @run driver TestSelectiveBarrierFlags -Xbatch -XX:CompileThreshold=100 -XX:-TieredCompilation -XX:+ShenandoahVerifyOptoBarriers
* @run driver TestSelectiveBarrierFlags -Xbatch -XX:CompileThreshold=100 -XX:-TieredCompilation
*/
import java.util.*;