stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8087153: EXCEPTION_ACCESS_VIOLATION when CDS RO section vanished on win32

Browse Source 
When mapping RW for debugging support, update space_info->read_only to reflect it is RW

Reviewed-by: dcubed, coleenp, iklam
This commit is contained in:
Chris Plummer 2015-06-19 14:23:39 -07:00
parent ae6886e4d9
commit c8b153a4e7
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hotspot/src/share/vm/memory/filemap.cpp
View File

@ -622,19 +622,15 @@ char* FileMapInfo::map_region(int i) {
size_t alignment = os::vm_allocation_granularity();
size_t size = align_size_up(used, alignment);
char *requested_addr = _header->region_addr(i);
bool read_only;
// If a tool agent is in use (debugging enabled), we must map the address space RW
if (JvmtiExport::can_modify_any_class() || JvmtiExport::can_walk_any_space()) {
read_only = false;
} else {
read_only = si->_read_only;
si->_read_only = false;
}
// map the contents of the CDS archive in this memory
char *base = os::map_memory(_fd, _full_path, si->_file_offset,
requested_addr, size, read_only,
requested_addr, size, si->_read_only,
si->_allow_exec);
if (base == NULL || base != requested_addr) {
fail_continue("Unable to map %s shared space at required address.", shared_region_name[i]);